Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-11419][filesystem] For recovery, wait until lease is revoked before truncate file #7588

Closed
wants to merge 2 commits into from

Conversation

EAlexRojas
Copy link
Contributor

What is the purpose of the change

This pull request performs the truncate of the hadoop file only after waiting for the lease to be revoked.

Brief change log

  • When resuming execution after a failure, wait until lease is revoked before performing truncate on the file.

Verifying this change

This change is already covered by existing tests, such as testRecoverWithState, testRecoverAfterMultiplePersistsState, etc in AbstractRecoverableWriterTest class.

An additional integration test could be added to test the case when this is used with a StreamingFileSink and simulate a taskmanager failure (?)

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@EAlexRojas EAlexRojas force-pushed the FLINK-11419 branch 3 times, most recently from 61450f1 to 5e5abaf Compare January 30, 2019 13:57
@kl0u
Copy link
Contributor

kl0u commented Jan 31, 2019

Hi @EAlexRojas, I will have a look on this PR today.

@kl0u
Copy link
Contributor

kl0u commented Jan 31, 2019

By the way, try to rebase on the master and relaunch the build on Travis. I will do the same, but if the tests do not pass for whatever reason, then we cannot merge the PR.

kl0u added a commit to kl0u/flink that referenced this pull request Jan 31, 2019
kl0u added a commit to kl0u/flink that referenced this pull request Jan 31, 2019
@kl0u
Copy link
Contributor

kl0u commented Jan 31, 2019

Thanks for the work @EAlexRojas . I will merge as soon as Travis gives green.

@EAlexRojas
Copy link
Contributor Author

@kl0u Travis test in my branch is green now :)
Looks like the errors in your branch are not related to the changes in this PR either (?)

kl0u added a commit to kl0u/flink that referenced this pull request Feb 1, 2019
@asfgit asfgit closed this in 892ff1d Feb 4, 2019
dianfu pushed a commit to dianfu/flink that referenced this pull request Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants