Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][docs] The CLI doc could not properly shown due to markdown i… #7443

Merged
merged 1 commit into from
Jan 10, 2019

Conversation

KarmaGYZ
Copy link
Contributor

@KarmaGYZ KarmaGYZ commented Jan 9, 2019

…ssue

What is the purpose of the change

The markdown treats the TOC as the last item in CLI use list, thus this list could not be shown properly. This PR revert the two paragraph to fix this issue.
CLI doc

Brief change log

  • Rever two paragraph to make CLI use list shown properly

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @KarmaGYZ. LGTM. Merging.

@tillrohrmann tillrohrmann merged commit 85dff90 into apache:master Jan 10, 2019
@KarmaGYZ KarmaGYZ deleted the cli-markdown branch January 11, 2019 02:19
tisonkun pushed a commit to tisonkun/flink that referenced this pull request Jan 17, 2019
…e#7443)

The markdown treats the TOC as the last item in CLI use list, thus this list could not be shown properly. This PR revert the two paragraph to fix this issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants