Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-10528] [table] Remove methods that were deprecated in Flink 1.4.0 #6826

Closed
wants to merge 1 commit into from

Conversation

fhueske
Copy link
Contributor

@fhueske fhueske commented Oct 11, 2018

What is the purpose of the change

  • Remove Table API methods that were deprecated in Flink 1.4.0.

Brief change log

  • remove TableEnvironment.sql() deprecated with FLINK-6442
  • remove StreamTableEnvironment.toDataStream() and TableConversions.toDataStream() deprecated with FLINK-6543
  • remove Table.limit() deprecated with FLINK-7821

Verifying this change

  • Run existing tests

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? I checked that the removed methods are not referenced in the docs or code comments.

…4.0.

- remove TableEnvironment.sql() deprecated with FLINK-6442
- remove StreamTableEnvironment.toDataStream() and TableConversions.toDataStream() deprecated with FLINK-6543
- remove Table.limit() deprecated with FLINK-7821
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. +1 from my side. Could you also perform a quick search if these methods are used in the website docs as well?

@hequn8128
Copy link
Contributor

+1 to merge.

I searched these methods in the Main source repository and find no occurrence.
https://github.com/apache/flink.git

There are some occurrences in the Website repository. However it is not related to this PR.
https://github.com/apache/flink-web.git

The occurrences are:
sql()
- 2016-05-24-stream-sql.md
- 2017-03-30-dynamic-tables.md
toDataStream()
- 2017-03-29-table-sql-api-update.md
limit()
- None

@fhueske
Copy link
Contributor Author

fhueske commented Oct 12, 2018

Thanks for the reviews.
I think we can leave the old blog posts as they are.

fhueske added a commit to fhueske/flink that referenced this pull request Oct 12, 2018
- remove TableEnvironment.sql() deprecated with FLINK-6442
- remove StreamTableEnvironment.toDataStream() and TableConversions.toDataStream() deprecated with FLINK-6543
- remove Table.limit() deprecated with FLINK-7821

This closes apache#6826.
@fhueske
Copy link
Contributor Author

fhueske commented Oct 12, 2018

merging

@asfgit asfgit closed this in 5e90ed9 Oct 12, 2018
@fhueske fhueske deleted the table-rmDeprecated branch October 15, 2018 16:51
Clarkkkkk pushed a commit to Clarkkkkk/flink that referenced this pull request Mar 7, 2019
- remove TableEnvironment.sql() deprecated with FLINK-6442
- remove StreamTableEnvironment.toDataStream() and TableConversions.toDataStream() deprecated with FLINK-6543
- remove Table.limit() deprecated with FLINK-7821

This closes apache#6826.

(cherry picked from commit 5e90ed9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants