[FLINK-10316][kinesis] bug was preventing FlinkKinesisProducer to connect to Kinesalite #6789
+35
−30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tweise
reviewed
Oct 4, 2018
| // per validation in AwsClientBuilder | ||
| throw new IllegalArgumentException(String.format("Either AWS region ('%s') or AWS endpoint ('%s') must be set in the config.", | ||
| AWSConfigConstants.AWS_REGION, AWSConfigConstants.AWS_REGION)); | ||
| if (isProducer) { |
There was a problem hiding this comment.
Since it isn't common, respective code should be moved into validateConsumerConfiguration and getValidatedProducerConfiguration.
There was a problem hiding this comment.
Thanks for the suggestion, I just pushed the code with this change and also updated the PR description.
…nect to Kinesalite
4419f4c
to
292839d
Compare
|
Thanks for the PR @diego-carvallo-tx. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Brief change log
KinesisConfigUtil.validateAwsConfiguration(Properties config)is used by bothFlinkKinesisConsumerandFlinkKinesisProducerbut AWS_REGION/AWS_ENDPOINT validation was performed only for Consumer who needs only one of them to be set. On the other side Producer requires AWS_REGION to be set even if AWS_ENDPOINT is defined to connect to local Kinesis. Since this validation code is not common for Consumer and Producer the change in this PR is moving out of this method the AWS_REGION/AWS_ENDPOINT validation which is now handled byvalidateConsumerConfiguration(...)andgetValidatedProducerConfiguration(...)(per suggestion in comments below by @tweise)Jira Note
There are 2 other tickets that could be closed along with this one since they all refer to the same issue: FLINK-9618 and FLINK-8936
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation