[FLINK-10400] Fail JobResult if application finished in CANCELED or FAILED state #6742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tisonkun
reviewed
Sep 24, 2018
| @@ -108,22 +118,39 @@ public long getNetRuntime() { | |||
| * | |||
| * @param classLoader to use for deserialization | |||
| * @return JobExecutionResult | |||
| * @throws WrappedJobException if the JobResult contains a serialized exception | |||
| * @throws JobExecutionException if the job execution did not succeed | |||
There was a problem hiding this comment.
this method might throws JobCancellationException if the job is cancelled, should be documented.
There was a problem hiding this comment.
Good point @tisonkun. Will add it.
…AILED state In case of the CANCELED state, the client will throw an JobCancellationException. In case of the FAILED state, the client will throw an JobExecutionException. This closes apache#6742.
0d3c552
to
b69c6eb
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Sep 26, 2018
…AILED state In case of the CANCELED state, the client will throw an JobCancellationException. In case of the FAILED state, the client will throw an JobExecutionException. This closes apache#6742.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Sep 26, 2018
…AILED state In case of the CANCELED state, the client will throw an JobCancellationException. In case of the FAILED state, the client will throw an JobExecutionException. This closes apache#6742.
asfgit
pushed a commit
that referenced
this pull request
Sep 27, 2018
…AILED state In case of the CANCELED state, the client will throw an JobCancellationException. In case of the FAILED state, the client will throw an JobExecutionException. This closes #6742.
Clarkkkkk
pushed a commit
to Clarkkkkk/flink
that referenced
this pull request
Mar 7, 2019
…AILED state In case of the CANCELED state, the client will throw an JobCancellationException. In case of the FAILED state, the client will throw an JobExecutionException. This closes apache#6742. (cherry picked from commit 2f88d42)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When generating a
JobExecutionResultfrom aJobResult, we fail the conversion if the application status was notSUCCEEDED.In case of the CANCELED state, the client will throw an JobCancellationException.
In case of the FAILED state, the client will throw an JobExecutionException.
Brief change log
ApplicationStatusfield toJobResultJobCancellationExceptionifApplicationStatuswasCANCELEDJobExecutionExceptionifApplicationStatuswasFAILEDVerifying this change
JobResultTest#testCancelledJobIsFailureResult,#testFailedJobIsFailureResult,#testCancelledJobThrowsJobCancellationExceptionand#testFailedJobThrowsJobExecutionException.Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation