Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hotfix][table] Fix bug in RowtimeValidator when getting custom TimestampExtractor #6575

Closed
wants to merge 2 commits into from
Closed

[hotfix][table] Fix bug in RowtimeValidator when getting custom TimestampExtractor #6575

wants to merge 2 commits into from

Conversation

jrthe42
Copy link
Contributor

@jrthe42 jrthe42 commented Aug 17, 2018

This pull request fixes a bug in RowtimeValidator , which may cause an exception when using custom TimestampExtractor in Flink SQL.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

twalthr
twalthr requested changes Aug 18, 2018
View reviewed changes
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR @jrthe42. Could you add a test for this in RowtimeTest?

@jrthe42
Copy link
Contributor Author

jrthe42 commented Aug 18, 2018 •
edited
Loading

A test has been added for using custom TimestampExtractor. cc @twalthr .

twalthr
twalthr approved these changes Aug 19, 2018
View reviewed changes
Copy link
Contributor

@twalthr twalthr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick update @jrthe42. Merging...

@asfgit asfgit closed this in 9fe70f2 Aug 19, 2018
asfgit pushed a commit that referenced this pull request Aug 19, 2018
@jrthe42 @twalthr
[FLINK-10169] [table] Fix error in RowtimeValidator when getting cust…
50c0fb8 
…om TimestampExtractor

This closes #6575.
@jrthe42 jrthe42 deleted the fix-RowtimeValidator branch April 2, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twalthr twalthr twalthr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrthe42 @twalthr