Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-9758] Fix ContinuousFileProcessingTest failure due to not setting runtimeContext #6260

Conversation

Myasuka
Copy link
Member

@Myasuka Myasuka commented Jul 5, 2018

What is the purpose of the change

Fix ContinuousFileProcessingTest failue due to not setting runtimeContext

Brief change log

ContinuousFileProcessingTest did not set runtime context for monitoringFunction, which will result in UT failure due to IllegalStateException if log level is set to DEBUG, just setRuntimeContext in this test.

Verifying this change

(Please pick either of the following options)

This change is already covered by existing tests, such as ContinuousFileProcessingTest with debug-level.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no

@yanghua
Copy link
Contributor

yanghua commented Jul 5, 2018

looks good from my side~

@dawidwys
Copy link
Contributor

Hi @Myasuka ,
Thank you for your contribution. How about extracting it to a helper method e.g. createTestContinousFileMonitoringFunction?

@Myasuka
Copy link
Member Author

Myasuka commented Jul 15, 2018

@dawidwys thanks for your suggestion, I have already refactor code with a helper method to create the continuous-monitoring function.

dawidwys pushed a commit to dawidwys/flink that referenced this pull request Jul 15, 2018
@dawidwys
Copy link
Contributor

+1, merging

@asfgit asfgit closed this in a7be2e1 Jul 15, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants