Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-8573] Extend ProgramInvocationException message with Job ID where applicable #6169

Closed
wants to merge 1 commit into from
Closed

[FLINK-8573] Extend ProgramInvocationException message with Job ID where applicable #6169

wants to merge 1 commit into from

Conversation

azagrebin
Copy link
Contributor

What is the purpose of the change

Print job id when program execution fails where it is possible.

Brief change log

  • add overloaded with JobId constructors to ProgramInvocationException
  • add job id to thrown ProgramInvocationException's where applicable

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@azagrebin
Copy link
Contributor Author

cc @tillrohrmann

tillrohrmann
tillrohrmann approved these changes Jun 14, 2018
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @azagrebin. LGTM. Will merge this PR.

@asfgit asfgit closed this in fc3ee68 Jun 15, 2018
sampathBhat pushed a commit to sampathBhat/flink that referenced this pull request Jul 26, 2018
@azagrebin
[FLINK-8573] Extend ProgramInvocationException message with Job ID wh…
1594385 
…ere applicable

This closes apache#6169.
This closes apache#5421.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
component=CommandLineClient
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@azagrebin @tillrohrmann @rmetzger