[FLINK-9357][tests][yarn] Add margins to exception excerpts #6009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
|
merging. |
zentol
added a commit
to zentol/flink
that referenced
this pull request
May 16, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
May 16, 2018
zentol
added a commit
to zentol/flink
that referenced
this pull request
May 16, 2018
cjolif
pushed a commit
to cjolif/flink
that referenced
this pull request
May 19, 2018
sampathBhat
pushed a commit
to sampathBhat/flink
that referenced
this pull request
Jul 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The yarn tests check the log files for exceptions to detect test failures. If detected a test will fail and an excerpt from the logs will be printed.
The excerpt content is currently the stack of the detected exception. This only works correctly if the stacktrace follows a specific formatting style; for example if an exception message contains an empty line the output will be cut off.
With this PR we also include the 10 lines before/after the found exception to make this a bit more reliable. As a side-effect we also get a little contextual information.
Brief change log
BufferingScannerclass to access previously read messages