[FLINK-8887][tests] Add single retry in MiniClusterClient #5657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 I think this makes sense if it unblocks merging test ports to master. I'm guessing we'll leave FLINK-8887 open until we have the proper fix? |
zentol
added a commit
to zentol/flink
that referenced
this pull request
Mar 8, 2018
|
merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR presents a test workaround for race-conditions in FLIP-6 (most notably FLINK-8887). Basically, every
MiniClusterClientcall is retried once after 500ms in case of certain exceptions.This is only a band-aid until a proper fix is in place so we can finally continue merging more test ports.
Brief change log
guardWithSingleRetryconvenience methodScheduledExecutortoMiniClusterClientMiniClusterVerifying this change
The change can be verified by cherry-picking this branch and running the
AbstractOperatorRestoreTestBase. Before this change there was always 1-2 tests failing, whereas now none should fail./cc @aljoscha @GJL