[FLINK-8670] Make MetricRegistryImpl#shutdown non blocking #5504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FutureUtils#completeAll(Collection) takes a collection of futures and returns a future which is completed after all of the given futures are completed. This also includes exceptional completions. Potentially occurring exceptions are recorded and combined into a single exception with which the resulting future is completed. FutureUtils#runAfterwards takes a future and runs a given action after the completion of the given future. This also includes an exceptional completion. In this case, a potentially occurring exception as the result of the provided action will be combined with the future's exception.
This commit makes the MetricRegistryImpl#shutdown method non blocking. Instead of waiting for the completion of the shutdown procedure, the method returns a future which is completed once the metric registry has completed the shut down.
zentol
reviewed
Feb 16, 2018
|
|
||
| /** | ||
| * Creates a new MetricRegistry and starts the configured reporter. | ||
| */ | ||
| public MetricRegistryImpl(MetricRegistryConfiguration config) { | ||
| this.scopeFormats = config.getScopeFormats(); | ||
| this.globalDelimiter = config.getDelimiter(); | ||
| this.delimiters = new ArrayList<>(10); |
There was a problem hiding this comment.
the number of delimiters is always equal to the number of reporters, so they should be initialized with the same size.
There was a problem hiding this comment.
Good point, will change it.
| */ | ||
| public void shutdown() { | ||
| public CompletableFuture<Void> shutdown() { |
There was a problem hiding this comment.
How about renaming this to shutdownAsync? (and possible keep shutdown() that just calls shutdownAsync().get()).
There was a problem hiding this comment.
Hmm, I actually would like to avoid that people can introduce blocking operations into the ClusterEntrypoint, for example. By offering a blocking shutdown method, I fear that this can easily happen again.
There was a problem hiding this comment.
Fair point. What about the renaming though?
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Feb 22, 2018
This commit makes the MetricRegistryImpl#shutdown method non blocking. Instead of waiting for the completion of the shutdown procedure, the method returns a future which is completed once the metric registry has completed the shut down. This closes apache#5504.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Feb 22, 2018
This commit makes the MetricRegistryImpl#shutdown method non blocking. Instead of waiting for the completion of the shutdown procedure, the method returns a future which is completed once the metric registry has completed the shut down. This closes apache#5504.
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Feb 23, 2018
This commit makes the MetricRegistryImpl#shutdown method non blocking. Instead of waiting for the completion of the shutdown procedure, the method returns a future which is completed once the metric registry has completed the shut down. This closes apache#5504.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This commit makes the MetricRegistryImpl#shutdown method non blocking. Instead
of waiting for the completion of the shutdown procedure, the method returns a
future which is completed once the metric registry has completed the shut down.
This PR is based on #5503.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation