[FLINK-8489][ES] Prevent side-effects when modifying user-config #5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good, but can this be guarded by a test? Otherwise I can see a someone in the future going like "oh, I have an idea how to 'optimize' this" and remove that copying operation. |
|
I'll add a test where we pass an unmodifiable map to the sink, that should cover it. |
|
Added a test for the I also modified the |
|
LGTM, once Travis is green. |
|
merging, |
zentol
added a commit
to zentol/flink
that referenced
this pull request
Jan 31, 2018
This closes apache#5378. This closes apache#4847. This closes apache#5305. This closes apache#5208. This closes apache#2192. This closes apache#2422. This closes apache#3478.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
The
ElasticsearchSinkBaseconstructor was removing entries from a user-provided collection. We now copy the collection to prevent side-effects.