Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] [table] Fix IndexOutOfBoundsException in DataStreamSortRule. #5370

Closed
wants to merge 1 commit into from

Conversation

fhueske
Copy link
Contributor

@fhueske fhueske commented Jan 26, 2018

What is the purpose of the change

Fixes an IndexOutOfBoundsException in DataStreamSortRule if a plan contains a sort operator without sorting fields (just LIMIT / FETCH).

Brief change log

  • Check number of sort fields before checking type of first field.

Verifying this change

Not covered by tests. ORDER BY without sorting fields are not supported cannot be translated. This change just prevents an exception but does not enable the feature.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? n/a

@twalthr
Copy link
Contributor

twalthr commented Jan 31, 2018

Thanks for the PR @fhueske. I will merge this.

@asfgit asfgit closed this in 2b76eca Jan 31, 2018
@fhueske fhueske deleted the tableFixSortIOOBE branch February 25, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants