[FLINK-8465] [flip6] Retrieve correct leader component address in ClusterClient #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
clusterClientLeaderAddress
branch
from
3d3743c
to
743e694
Compare
GJL
approved these changes
Jan 26, 2018
|
Thanks for the review @GJL. Rebasing and merging once Travis gives green light. |
tillrohrmann
force-pushed
the
clusterClientLeaderAddress
branch
from
743e694
to
0026024
Compare
…sterClient Rename ClusterClient#getJobManagerAddress into #getClusterConnectionInfo. The returned LeaderConnectionInfo contains the address of the leading cluster component. In the old code this is the JobManager whereas in Flip-6 it is the Dispatcher. This closes apache#5321.
tillrohrmann
force-pushed
the
clusterClientLeaderAddress
branch
from
0026024
to
25b1dc0
Compare
tillrohrmann
added a commit
to tillrohrmann/flink
that referenced
this pull request
Jan 29, 2018
…sterClient Rename ClusterClient#getJobManagerAddress into #getClusterConnectionInfo. The returned LeaderConnectionInfo contains the address of the leading cluster component. In the old code this is the JobManager whereas in Flip-6 it is the Dispatcher. This closes apache#5321.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Rename ClusterClient#getJobManagerAddress into #getClusterConnectionInfo. The
returned LeaderConnectionInfo contains the address of the leading cluster
component. In the old code this is the JobManager whereas in Flip-6 it is the
Dispatcher.
Verifying this change
This change is already covered by existing tests.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (no)Documentation