[FLINK-7571] [table] Fix translation of TableSource with time indicators

[fhueske]

What is the purpose of the change

This PR fixes the translation / code generation for table scans against table sources that include tiem indicator fields. The behavior was broken during the recent time indicator refactoring.
I added a test to ensure the feature remains working.

Brief change log

• Add an ITCase to ensure that table sources with time indicators are correctly executed
• Fix the registration of table sources with time indicators

Verifying this change

This change added tests and can be verified as follows:
Run TimeAttributesITCase.testTableSourceWithTimeIndicators()

Does this pull request potentially affect one of the following parts:

• Dependencies (does it add or upgrade a dependency): no
• The public API, i.e., is any changed class annotated with no
• The serializers: no
• The runtime per-record code paths (performance sensitive): no
• Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: no

Documentation

• Does this pull request introduce a new feature? no
• If yes, how is the feature documented? n/a

[uybhatti]

For rowtime we need to replace the index of specific field, but here you are adding index at the end of row. Same thing applies for FieldNames and FieldTypes.

[fhueske]

That's how rowtime fields are handled at the moment. They are always appended at the end of the row.

There is a JIRA to use existing fields as rowtime fields (https://issues.apache.org/jira/browse/FLINK-7446) but this has not been implemented yet. I'm currently working on a PR for that.

[uybhatti]

Thanks, Actually we can define existing field as the rowtime field, when we convert DataStream to Table. That's why I was little bit confused, but we have PR for TableSource then it's good.

[fhueske]

@wuchong can you have a look at this PR?
It fixes the code generation for table sources with time attributes.
Thanks!

[wuchong]

Hi @fhueske , thanks for the work! It is a very important fix! I'm fine with the changes.

+1 to merge

[fhueske]

Thanks for the review @wuchong!

Merging