Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-7438][build]Remove useless import, avoid warnings #4570

Closed
wants to merge 1 commit into from
Closed

[FLINK-7438][build]Remove useless import, avoid warnings #4570

wants to merge 1 commit into from

Conversation

yew1eb
Copy link
Contributor

@yew1eb yew1eb commented Aug 22, 2017

What is the purpose of the change

Avoid warnings，details: ISSUE #FLINK-7438.

Brief change log

Remove useless "import org.apache.flink.util.OutputTag" in DataStream.scala, AllWindowedStream.scala, WindowedStream.scala

Verifying this change

This change is already covered by existing tests.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@tedyu
Copy link
Contributor

tedyu commented Aug 29, 2017

lgtm

@yew1eb
Copy link
Contributor Author

yew1eb commented Aug 31, 2017

Hi @twalthr @zentol,
Please helps to review, Thank you very much. 🍻

@yew1eb
Copy link
Contributor Author

yew1eb commented Sep 1, 2017

CC @aljoscha 😆

@yew1eb
Copy link
Contributor Author

yew1eb commented Sep 6, 2017

CC @zentol

@yew1eb yew1eb changed the title [FLINK-7438][DataStream API]Remove useless import, avoid warnings [FLINK-7438][build]Remove useless import, avoid warnings Sep 25, 2017
@yew1eb
Copy link
Contributor Author

yew1eb commented Sep 25, 2017

@zentol Let me know what you think about this PR now :)

@yew1eb yew1eb closed this Sep 26, 2017
@yew1eb yew1eb reopened this Sep 26, 2017
@yew1eb
Copy link
Contributor Author

yew1eb commented Sep 26, 2017

can someone review this please? :)

@zentol
Copy link
Contributor

zentol commented Sep 28, 2017

merging.

@yew1eb
Copy link
Contributor Author

yew1eb commented Sep 28, 2017

@zentol thank you very much!. 🍻

@asfgit asfgit closed this in 40fbe66 Sep 28, 2017
yew1eb added a commit to yew1eb/flink that referenced this pull request Oct 4, 2017
@yew1eb
[FLINK-7438] [scala] Remove unused import
df93b66 
These classes imported the org.apache.flink.util.OutputTag class, which was however not used since
a scala OutputTag class exists in the same package. This caused the compiler to throw warnings
as the import was overshadowed by the package local class.

This closes apache#4570.
@yew1eb yew1eb deleted the FLINK-7438 branch January 25, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component=API/DataStream component=API/Scala component=BuildSystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yew1eb @tedyu @zentol @rmetzger