Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-7415][Cassandra Connector] Add comments for cassandra-connector test classes #4519

Closed
wants to merge 4 commits into from

Conversation

yew1eb
Copy link
Contributor

@yew1eb yew1eb commented Aug 10, 2017

What is the purpose of the change

Help beginners follow it with less confusion.

Brief change log

  • Add comments for cassandra test classes

Verifying this change

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

@yew1eb
Copy link
Contributor Author

yew1eb commented Aug 10, 2017

I ran the test class with an exception, I found the cause finally.

@yew1eb yew1eb changed the title [FLINK-7415][Cassandra Connector] Add comments for BatchExample.java [FLINK-7415][Cassandra Connector] Add comments for cassandra-connector test classes Aug 10, 2017
@zentol
Copy link
Contributor

zentol commented Aug 14, 2017

+1.

@zentol
Copy link
Contributor

zentol commented Aug 15, 2017

merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants