Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-7343][kafka] Increase Xmx for tests #4456

Closed
wants to merge 2 commits into from

Conversation

pnowojski
Copy link
Contributor

As reported by @NicoK, sometimes 1000m was not enough memory to run at-least-once tests with broker failures on Travis. I remember having the same issue in #4239 where I have set this same value to 2048. Hopefully it will solve the problems.

@greghogan
Copy link
Contributor

+1 this matches the parent pom.xml. Wondering if the same change would fix flink-hbase always failing for me when running mvn verify.

@pnowojski pnowojski changed the title [FLINK-6996][kafka] Increase Xmx for tests [FLINK-7343][kafka] Increase Xmx for tests Aug 2, 2017
@NicoK
Copy link
Contributor

NicoK commented Aug 2, 2017

yes, seems like it was changed from -Xmx800m to -Xmx1536m by FLINK-6128 and again to -Xmx2048m by FLINK-7004 without changing it here. The question should rather be whether we need the specialised options anyway or whether we can remove them.
I tested the latter (removing the <argLine>...</argLine> lines but keeping the <forkCount>1</forkCount>) and then the root pom's values are inherited which may be a better solution anyway.

@pnowojski
Copy link
Contributor Author

@NicoK sounds reasonable however this will drop -UseGCOverheadLimit flag. It should be fine when at the same time we increase the Xmx. Btw, having UseGCOverheadLimit seems a little bit fishy in the first place...

Pushing fixup with inheriting values from the parent pom.

Sometimes 1000m was not enough memory to run at-least-once tests with broker failures on Travis
@tzulitai
Copy link
Contributor

tzulitai commented Aug 7, 2017

+1, LGTM.

@zentol
Copy link
Contributor

zentol commented Aug 7, 2017

merging.

zentol pushed a commit to zentol/flink that referenced this pull request Aug 7, 2017
Sometimes 1000m was not enough memory to run at-least-once tests with broker failures on Travis

This closes apache#4456.
@pnowojski
Copy link
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants