Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FLINK-7204] [core] CombineHint.NONE #4350

Closed
wants to merge 3 commits into from
Closed

[FLINK-7204] [core] CombineHint.NONE #4350

wants to merge 3 commits into from

Commits on Jul 17, 2017

  1. [FLINK-7204] [core] CombineHint.NONE 

    FLINK-3477 added a hash-combine preceding the reducer configured with
CombineHint.HASH or CombineHint.SORT (default). In some cases it may be
useful to disable the combiner in ReduceNode by specifying a new
CombineHint.NONE value.
    @greghogan
    greghogan committed Jul 17, 2017
    Configuration menu
    Copy the full SHA
    1adbce8 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2017

  1. Address comments 

    ReduceNode processes CombineHint.NONE by setting the ReduceProperties
combinerStrategy to DriverStrategy.NONE upon which ReduceProperties now
excludes the combiner.

New test ReduceCompilationTest#testGroupedReduceWithoutCombiner checks
the program compilation when excluding the combiner with
CombineHint.NONE. Gelly now excludes the combiner when simplifying
graphs as used in most algorithm unit and integraiton tests.
    @greghogan
    greghogan committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    ba47d93 View commit details
    Browse the repository at this point in the history

  2. To be squashed 

    Simplify the new testGroupedReduceWithoutCombiner by grouping on field
position keys rather than a KeySelector.
    @greghogan
    greghogan committed Jul 19, 2017
    Configuration menu
    Copy the full SHA
    2ae08a9 View commit details
    Browse the repository at this point in the history