[FLINK-6731] [tests] Activate strict checkstyle for flink-tests #4295
Conversation
366b6c0
to
9270553
Compare
|
The |
|
Import changes look ok. |
|
Whitespace changes look ok. |
| @@ -30,6 +29,9 @@ | |||
|
|
|||
| import org.junit.Assert; | |||
|
|
|||
| /** | |||
| * | |||
| * | ||
| * @param <E> the type of elements maintained by this set | ||
| */ | ||
| private static final class ConcurrentSet<E> extends AbstractSet<E> implements Serializable { |
There was a problem hiding this comment.
You could also use Collections.newSetFromMap(new HashMap<>())
There was a problem hiding this comment.
Correction: the import was reordered in a recent commit but removed in your commit yesterday. So have revered the inclusion of this class.
| @@ -324,7 +322,7 @@ public void notifyCheckpointComplete(long checkpointId) { | |||
| private static class LeftIdentityCoRichFlatMapFunction extends RichCoFlatMapFunction<Long, Long, Long> | |||
| implements CheckpointListener { | |||
|
|
|||
| static final List<Long>[] completedCheckpoints = createCheckpointLists(PARALLELISM); | |||
There was a problem hiding this comment.
did you intentionally remove final? (there are other instances of change)
There was a problem hiding this comment.
I've fixed the instances in this file. Variables are now uppercase.
| @@ -168,6 +173,6 @@ private static void runKMeans(ExecutionEnvironment env) throws Exception { | |||
|
|
|||
| clusteredPoints.output(new DiscardingOutputFormat<Tuple2<Integer, KMeans.Point>>()); | |||
|
|
|||
| env.execute("KMeans Example"); | |||
| env.execute("kmeans Example"); | |||
There was a problem hiding this comment.
Not sure if we have to change this.
| @@ -36,9 +36,9 @@ | |||
| private final long maxAdditionalSessionGap; | |||
|
|
|||
| public GeneratorConfiguration(long allowedLateness, | |||
There was a problem hiding this comment.
let's move the allowedLateness argument to the next line as well.
| @@ -39,9 +39,9 @@ | |||
| * @return event for an keyed event generator | |||
| */ | |||
| E createEvent(K key, | |||
9270553
to
7afd05c
Compare
| @@ -65,7 +68,7 @@ public Centroid map(String c) { | |||
| } | |||
| }); | |||
|
|
|||
| // set number of bulk iterations for KMeans algorithm | |||
| // set number of bulk iterations for kmeans algorithm | |||
There was a problem hiding this comment.
Another instance of "kmeans" renaming
There was a problem hiding this comment.
I reverted these and the additional instances. It looks to have happened when renaming KMeansSingleStepTest#KMeans.
| @@ -70,7 +69,7 @@ public static void main(String[] args) throws Exception { | |||
| DataSet<Centroid> centroids = env.fromElements(centersData.split("\n")) | |||
| .map(new TupleCentroidConverter()); | |||
|
|
|||
| // set number of bulk iterations for KMeans algorithm | |||
| // set number of bulk iterations for kmeans algorithm | |||
|
+1 with green light from travis. |
3a848a2
to
182f5a8
Compare
No description provided.