Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-6056] [build]apache-rat exclude flink directory in tools #3540

Closed
wants to merge 1 commit into from
Closed

[FLINK-6056] [build]apache-rat exclude flink directory in tools #3540

wants to merge 1 commit into from

Conversation

shijinkui
Copy link
Contributor

The flink* directory in the tools is temporary cloned when build distribution.
So when build the Flink project, we should exclude the flink* directory.

  • General

    • The pull request references the related JIRA issue ("[FLINK-6056] apache-rat exclude flink directory in tools")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation

    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build

    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

@shijinkui shijinkui changed the title [FLINK-6056] apache-rat exclude flink directory in tools [FLINK-6056] [build]apache-rat exclude flink directory in tools Mar 15, 2017
@zentol
Copy link
Contributor

zentol commented Mar 15, 2017

Why exactly is it a problem if the rat-plugin checks the tools directory?

@shijinkui
Copy link
Contributor Author

Why exactly is it a problem if the rat-plugin checks the tools directory?
There no necessary to check the tmp flink project in the tools, because it will extra cost some time when build the main project.

@StephanEwen
Copy link
Contributor

I am a bit confused... I think there is no tools/flink* directory that would need an exclusion...

@shijinkui
Copy link
Contributor Author

I am a bit confused... I think there is no tools/flink* directory that would need an exclusion...

When execute tools/create_release_files.sh, it will clone flink project from apache. Also we had add tools/flink* in the .gitignore

@StephanEwen
Copy link
Contributor

@shijinkui Got it, thanks.

+1 to merge this

@StephanEwen
Copy link
Contributor

Merging this...

StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Mar 21, 2017
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Mar 21, 2017
StephanEwen pushed a commit to StephanEwen/flink that referenced this pull request Mar 21, 2017
@asfgit asfgit closed this in 96ec655 Mar 21, 2017
p16i pushed a commit to p16i/flink that referenced this pull request Apr 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants