[FLINK-5402] [FLINK-5389] Increase test timeouts #3430
Conversation
| @@ -135,7 +135,7 @@ public void testGetAddress() { | |||
| * @throws ExecutionException | |||
| * @throws InterruptedException | |||
| */ | |||
| @Test(timeout = 1000) | |||
| @Test | |||
There was a problem hiding this comment.
@tillrohrmann Is is OK to remove these timeouts? We still catch this with the build timeout stack traces if no progress happens. As an alternative, we can increase the timeout to a higher value.
There was a problem hiding this comment.
It should be ok to remove the timeout, but I think that the build timeout stack traces are not so nice to see which test case actually caused the timeout. The reason for this is that there are multiple test cases being executed in parallel.
There was a problem hiding this comment.
OK, never noticed this problem, but will check it the next time. Maybe we can improve something. ;-) I'll leave the JUnit timeout and increase it to a higher value like 60000. I think that's a good compromise?
Some users reported running into timeouts due to too "aggressive" timeouts for certain configurations (as mentioned by Dawid in FLINK-5402).
The changed timeouts don't affect the failure free runtime of the tests.