[docker] improve Dockerfile host configuration #2981
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mxm
commented
Dec 9, 2016
mxm
commented
- configure job manager address for both operation modes
- introduce argument to specify the external job manager address
- replace ARG with ENV for backwards-compatibility
- EXPOSE web port and RPC port
- configure job manager address for both operation modes - introduce argument to specify the external job manager address - replace ARG with ENV for backwards-compatibility - EXPOSE web port and RPC port
mxm
added a commit
to mxm/flink
that referenced
this pull request
Dec 16, 2016
- configure job manager address for both operation modes - introduce argument to specify the external job manager address - replace ARG with ENV for backwards-compatibility - EXPOSE web port and RPC port This closes apache#2981.
mxm
added a commit
to mxm/flink
that referenced
this pull request
Dec 16, 2016
- configure job manager address for both operation modes - introduce argument to specify the external job manager address - replace ARG with ENV for backwards-compatibility - EXPOSE web port and RPC port This closes apache#2981.
tonycox
pushed a commit
to tonycox/flink
that referenced
this pull request
Dec 23, 2016
- configure job manager address for both operation modes - introduce argument to specify the external job manager address - replace ARG with ENV for backwards-compatibility - EXPOSE web port and RPC port This closes apache#2981.
| @@ -40,3 +39,6 @@ elif [ "$1" = "taskmanager" ]; then | |||
| else | |||
| $@ | |||
| fi | |||
|
|
|||
| # prevent script to exit | |||
| tail -f /dev/null | |||
There was a problem hiding this comment.
Why is this needed?
https://github.com/apache/flink/blob/master/flink-contrib/docker-flink/Dockerfile#L49 already prevents the container from exiting till the daemon dies.
This on the other hand will never let the container exit.
joseprupi
pushed a commit
to joseprupi/flink
that referenced
this pull request
Feb 12, 2017
- configure job manager address for both operation modes - introduce argument to specify the external job manager address - replace ARG with ENV for backwards-compatibility - EXPOSE web port and RPC port This closes apache#2981.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.