[FLINK-5185] [Table API & SQL] Decouple BatchTableSourceScan with TableSourceTable #2921
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Plan: junit Reviewers: kete.yangkt Differential Revision: http:https://phabricator.taobao.net/D6601
wuchong
reviewed
Dec 2, 2016
| @@ -32,18 +31,20 @@ class BatchTableSourceScan( | |||
| cluster: RelOptCluster, | |||
| traitSet: RelTraitSet, | |||
| table: RelOptTable, | |||
| rowType: RelDataType) | |||
| extends BatchScan(cluster, traitSet, table, rowType) { | |||
| val tableSource: BatchTableSource[_]) | |||
There was a problem hiding this comment.
Do we have to declare this field as val ? It seems that it is only used in this class.
There was a problem hiding this comment.
@wuchong , Thanks for your review. For later use, the projection pushdown rule needs to get the actual tablesource of the BatchTableSourceScan, then do something on it.
|
Thanks for the PR @beyond1920! |
|
merging |
fhueske
pushed a commit
to fhueske/flink
that referenced
this pull request
Dec 2, 2016
…ourceScan. This closes apache#2921.
static-max
pushed a commit
to static-max/flink
that referenced
this pull request
Dec 13, 2016
…ourceScan. This closes apache#2921.
joseprupi
pushed a commit
to joseprupi/flink
that referenced
this pull request
Feb 12, 2017
…ourceScan. This closes apache#2921.
hequn8128
pushed a commit
to hequn8128/flink
that referenced
this pull request
Jun 22, 2017
…ourceScan. This closes apache#2921.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pr aims to decouple BatchTableSourceScan with TableSourceTable for further optimization, e.g, projection pushdown/filter pushdown/query pushdown. The principle is let BatchTableSourceScan directly holding TableSource instead of holding TableSourceTable.
The main changes including: