[FLINK-5074] [runtime] add a zookeeper based running job registry #2903
Conversation
|
Looks good to me! I think it would be good to add a test to this, based on a Curator TestingServer. |
| public void before() { | ||
| try { | ||
| testingServer = new TestingServer(); | ||
| } catch (Exception e) { |
There was a problem hiding this comment.
I would just add throws Exception to the method signature here, rather than catching and wrapping the exception. Makes error stack traces easier to read.
As a general rule: I think one should never need to explicitly throw a RuntimeException.
(I know Flink has a few places where it does it, but these are in my opinion errors from the past, during the time when we were still learning)
|
@StephanEwen done |
|
@StephanEwen I have modified according to your comments. Can this pr be merged, I have a new jira need to based on this one. Thank you very much |
|
I think this looks good, thanks! |
This pr is for jira #5074.
Implement a zookeeper based running job registry for flip-6. It will write the running job info to zookeeper and support querying job status.