[FLINK-35935][table] Fix RTAS not supporting LIMIT #25185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
02d6a52
to
e2bb410
Compare
lincoln-lil
reviewed
Aug 13, 2024
There was a problem hiding this comment.
@xuyangzhong Thanks for fixing this! The only question from my side is the reason why single parallelism must set for these tests?
| QueryOperation query = | ||
| new PlannerQueryOperation( | ||
| context.toRelRoot(asQuerySqlNode).project(), | ||
| context.toRelRoot(validated).project(), |
| @@ -78,6 +78,29 @@ void testReplaceTableAS() throws Exception { | |||
| verifyCatalogTable(expectCatalogTable, getCatalogTable("target")); | |||
| } | |||
|
|
|||
| @Test | |||
| void testReplaceTableASWithLimit() throws Exception { | |||
| env().setParallelism(1); | |||
There was a problem hiding this comment.
Why must be single parallelism?
| @@ -108,6 +108,27 @@ void testCreateOrReplaceTableAS() throws Exception { | |||
| verifyCatalogTable(expectCatalogTable, getCatalogTable("target")); | |||
| } | |||
|
|
|||
| @Test | |||
| void testCreateOrReplaceTableASWithLimit() throws Exception { | |||
| env().setParallelism(1); | |||
|
Hi, @lincoln-lil . The reason is: The plan will be optimized to |
|
@xuyangzhong So at least we can use a sort clause for batch tests to get the stable result? |
|
@lincoln-lil You're right. I have replaced all |
xuyangzhong
added a commit
to xuyangzhong/flink
that referenced
this pull request
Aug 15, 2024
This closes apache#25185 (cherry picked from commit 729b8b8)
xuyangzhong
added a commit
to xuyangzhong/flink
that referenced
this pull request
Aug 15, 2024
This closes apache#25185 (cherry picked from commit 729b8b8)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
When using
SqlReplaceTableAsConverterto convert SqlNode,SqlReplaceTableAsConverterwrongly used the original queryasQuerySqlNode. Actually it should use the validated SqlNode.Brief change log
Verifying this change
Many tests (including UT and IT) have been added to verify this pr.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation