Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Fix npm issue in document Build #25147

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Samrat002
Copy link
Contributor

@Samrat002 Samrat002 commented Aug 2, 2024

What is the purpose of the change

Fix Document Build issue due to npm build is getting error .
https://github.com/apache/flink/actions/runs/10212497617

Brief change log

  • upgrade protractor dependencies in npm package.json

Verifying this change

Running build action to succeed
https://github.com/apache/flink/actions/runs/10212536568/job/28256049360

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 2, 2024

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

changes

skip doc build
@rmetzger
Copy link
Contributor

rmetzger commented Aug 2, 2024

Minor note: the commit message does not include the [hotfix] prefix.

I don't understand how this change is fixing the npm build issue. Can you explain?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants