[FLINK-32852][JUnit5 Migration] Migrate the scheduler package of flink-runtime module to JUnit5 #24732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-runtime module to JUnit5
|
hi, @JingGe @1996fanrui Could you help take a look if you had the free time ? |
1996fanrui
reviewed
Apr 29, 2024
There was a problem hiding this comment.
Some classes should be changed, but they are missed, so I commented here:
- Remove @ExtendWith(TestLoggerExtension.class)
- EnforceMinimalIncreaseRescalingControllerTest
- DefaultExecutionDeployerTest
- StopWithSavepointTest
- Don't use
org.junit.Assert- StateValidator
- SchedulerTestingUtils
- MockStateWithExecutionGraphContext
- public can be removed for test method
- AdaptiveSchedulerTest
- StateLocalitySlotAssignerTest
- public can be removed for test class
- you can search
public class, I saw a lot of classes need to remove it. - Update
isEqualTo(0)toisZero- AdaptiveSchedulerTest
- AllToAllBlockingResultInfoTest
- Update
isEqualTo(1)toisOne- ExecutionTimeBasedSlowTaskDetectorTest
- SpeculativeExecutionTest
- PointwiseBlockingResultInfoTest
- DefaultVertexParallelismAndInputInfosDeciderTest
- AdaptiveSchedulerTest
- AllToAllBlockingResultInfoTest
- hasSameSizeAs
- DefaultVertexParallelismAndInputInfosDeciderTest (line 445)
Comment on lines
+120
to
+139
|
|
||
| @Override | ||
| public void beforeEach(ExtensionContext context) throws Exception { | ||
| miniClusterResource.before(); | ||
| } | ||
|
|
||
| @Override | ||
| public void afterEach(ExtensionContext context) throws Exception { | ||
| miniClusterResource.after(); | ||
| } | ||
|
|
||
| @Override | ||
| public void before(ExtensionContext context) throws Exception { | ||
| miniClusterResource.before(); | ||
| } | ||
|
|
||
| @Override | ||
| public void after(ExtensionContext context) throws Exception { | ||
| miniClusterResource.after(); | ||
| } |
There was a problem hiding this comment.
I saw the mini cluster resource didn't close for each test before. I guess one reason is performance.
Start a mini cluster needs some times, if we restart it frequently, test will take a long time.
Is it necessary for this PR?
| stateWithExecutionGraph.getGloballyTerminalStateFuture().get(), | ||
| is(JobStatus.FINISHED)); | ||
| assertThatFuture(stateWithExecutionGraph.getGloballyTerminalStateFuture()) | ||
| .isCompletedWithValue(JobStatus.FINISHED); | ||
| } | ||
|
|
||
| @Test |
| finishedBackgroundTask.getTerminationFuture().join(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testFinishedBackgroundTaskDoesNotContainAResult() { | ||
| final BackgroundTask<Void> finishedBackgroundTask = BackgroundTask.finishedBackgroundTask(); | ||
|
|
||
| assertTrue(finishedBackgroundTask.getResultFuture().isCompletedExceptionally()); | ||
| assertThatFuture(finishedBackgroundTask.getResultFuture()).isCompletedExceptionally(); | ||
| } | ||
|
|
||
| @Test | ||
| public void testNormalCompletionOfBackgroundTask() { |
| @@ -182,21 +182,20 @@ private void triggerComputeNumOfSubpartitions(IntermediateResult result) { | |||
| private void assertNetworkMemory( | |||
| List<SlotSharingGroup> slotSharingGroups, List<MemorySize> networkMemory) { | |||
|
|
|||
| assertEquals(slotSharingGroups.size(), networkMemory.size()); | |||
| assertThat(networkMemory.size()).isEqualTo(slotSharingGroups.size()); | |||
Comment on lines
280
to
281
| assertThat(slotSharingGroups.size()).isEqualTo(3); | ||
| assertThat(parallelisms.size()).isEqualTo(3); |
Thank you very much for the patient-check and review. There're some class referenced by other class. so I kept the As shown in the commit messages, I split the patches by commit. |
|
@flinkbot run azure |
1996fanrui
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
[FLINK-32852][JUnit5 Migration] Migrate the scheduler package of flink-runtime module to JUnit5
Brief change log
[FLINK-32852][JUnit5 Migration] Migrate the scheduler package of flink-runtime module to JUnit5
Verifying this change
This change is already covered by existing tests, such as (please describe tests).
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation