Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-4420] [table] Introduce star(*) to select all of the columns in the table #2384

Closed
wants to merge 1 commit into from

Conversation

wuchong
Copy link
Member

@wuchong wuchong commented Aug 18, 2016

Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the How To Contribute guide.
In addition to going through the list, please provide a meaningful description of your changes.

  • General
    • The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
    • The pull request addresses only one issue
    • Each commit in the PR has a meaningful commit message (including the JIRA id)
  • Documentation
    • Documentation has been added for new functionality
    • Old documentation affected by the pull request has been updated
    • JavaDoc for public methods has been added
  • Tests & Build
    • Functionality added by the pull request is covered by tests
    • mvn clean verify has been executed successfully locally or a Travis build has passed

When we have many columns in a table, it's easy to select all the columns if we support select *.

In Scala:

val result = table.select('*);

In Java:

Table result = table.select("*");

In addition, I add some constrains for field alias. Forbid * as a field name.

@twalthr
Copy link
Contributor

twalthr commented Aug 29, 2016

Thanks @wuchong. The PR looks good. I will merge this...

@asfgit asfgit closed this in 1f17886 Aug 29, 2016
haoch pushed a commit to haoch/flink that referenced this pull request Sep 10, 2016
@wuchong wuchong deleted the star branch May 15, 2017 02:12
hequn8128 pushed a commit to hequn8128/flink that referenced this pull request Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants