Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-30180][docs] Remove the description of Filesystem supporting for the lookup in the Supported Connectors section #21381

Merged
merged 2 commits into from
Nov 24, 2022

Conversation

YesOrNo828
Copy link
Contributor

What is the purpose of the change

In the Supported Connectors section, the graph shows that the Filesystem connector supports the lookup source. Actually, it doesn't.

So I want to remove this description.

Brief change log

  • The documentation in the Supported Connectors section.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no) no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no) no
  • The serializers: (yes / no / don't know) no
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know) no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know) no
  • The S3 file system connector: (yes / no / don't know) no

Documentation

  • Does this pull request introduce a new feature? (yes / no) no
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) docs

…or the lookup in the Supported Connectors section
@flinkbot
Copy link
Collaborator

flinkbot commented Nov 24, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YesOrNo828 Thanks for the PR, can you also change the Chinese documentation page on this?

@MartijnVisser MartijnVisser self-assigned this Nov 24, 2022
@YesOrNo828
Copy link
Contributor Author

Hi @MartijnVisser, Done with the Chinese documentation. Please have a look.

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YesOrNo828 Thanks, LGTM

@MartijnVisser MartijnVisser merged commit 752321d into apache:master Nov 24, 2022
akkinenivijay pushed a commit to krisnaru/flink that referenced this pull request Feb 11, 2023
…or the lookup in the Supported Connectors section (apache#21381)

* [FLINK-30180][docs] Remove the description of Filesystem supporting for the lookup in the Supported Connectors section

* [FLINK-30180][docs] Change chinese documentation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants