[FLINK-28617][SQL Gateway] Support stop job statement in SqlGatewayService #21292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI failed due to an unrelated Kafka connector test. We may take a look at the codes first. cc @fsk119 |
|
@flinkbot run azure |
link3280
force-pushed
the
FLINK-28617
branch
from
d0d1f7d
to
e12294a
Compare
|
Rebased on the recent master to see if the test failure still exists. |
link3280
force-pushed
the
FLINK-28617
branch
from
256b7ff
to
26da341
Compare
link3280
force-pushed
the
FLINK-28617
branch
from
26da341
to
911b28d
Compare
|
ping @fsk119 |
fsk119
reviewed
Dec 15, 2022
...ateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java
Outdated
Show resolved
Hide resolved
...ql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceITCase.java
Outdated
Show resolved
Hide resolved
...ql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceITCase.java
Outdated
Show resolved
Hide resolved
...ql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceITCase.java
Outdated
Show resolved
Hide resolved
|
@flinkbot run azure |
fsk119
reviewed
Dec 16, 2022
...k-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/TestUtils.java
Outdated
Show resolved
Hide resolved
...ateway/src/main/java/org/apache/flink/table/gateway/service/operation/OperationExecutor.java
Outdated
Show resolved
Hide resolved
...ql-gateway/src/test/java/org/apache/flink/table/gateway/service/SqlGatewayServiceITCase.java
Outdated
Show resolved
Hide resolved
|
Updated as suggested. CI turns green. cc @fsk119 |
fsk119
approved these changes
Dec 18, 2022
Comment on lines
+460
to
+468
| } catch (Exception e) { | ||
| throw new FlinkException( | ||
| "Could not stop job " | ||
| + stopJobOperation.getJobId() | ||
| + " in session " | ||
| + operationHandle.getIdentifier() | ||
| + ".", | ||
| e); | ||
| } |
There was a problem hiding this comment.
nit: It's a little trivial to catch the same exception twice with a similar msg. In the next PR, we can remove this.
chucheng92
pushed a commit
to chucheng92/flink
that referenced
this pull request
Feb 3, 2023
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Support stop job statement in SqlGatewayService. Subtask of FLIP-222.
Brief change log
Verifying this change
Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation