-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-29709][Connector/Pulsar] Bump the Pulsar to latest 2.10.2 #21204
Conversation
c829d30
to
754128d
Compare
32f3839
to
7ebada2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Waiting for CI status...
|
@flinkbot run azure |
7ebada2
to
0aa0790
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems the failure fails exactly on the Pulsar tests:
Nov 02 04:14:52 [ERROR] org.apache.flink.connector.pulsar.sink.writer.topic.TopicMetadataListenerTest Time elapsed: 6.818 s <<< ERROR!
Nov 02 04:14:52 java.lang.IllegalStateException: org.apache.pulsar.broker.PulsarServerException: java.util.concurrent.ExecutionException: java.lang.NoSuchMethodError: com.github.benmanes.caffeine.cache.AsyncLoadingCache.asMap()Ljava/util/concurrent/ConcurrentMap;
Nov 02 04:14:52 at org.apache.flink.connector.pulsar.testutils.runtime.mock.PulsarMockRuntime.startUp(PulsarMockRuntime.java:60)
Nov 02 04:14:52 at org.apache.flink.connector.pulsar.testutils.PulsarTestEnvironment.beforeAll(PulsarTestEnvironment.java:90)
Nov 02 04:14:52 at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.lambda$invokeBeforeAllCallbacks$12(ClassBasedTestDescriptor.java:395)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Nov 02 04:14:52 at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.invokeBeforeAllCallbacks(ClassBasedTestDescriptor.java:395)
Nov 02 04:14:52 at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:211)
Nov 02 04:14:52 at org.junit.jupiter.engine.descriptor.ClassBasedTestDescriptor.before(ClassBasedTestDescriptor.java:84)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:148)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService.invokeAll(ForkJoinPoolHierarchicalTestExecutorService.java:129)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$6(NodeTestTask.java:155)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:141)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:137)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$9(NodeTestTask.java:139)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:138)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:95)
Nov 02 04:14:52 at org.junit.platform.engine.support.hierarchical.ForkJoinPoolHierarchicalTestExecutorService$ExclusiveTask.compute(ForkJoinPoolHierarchicalTestExecutorService.java:185)
Nov 02 04:14:52 at java.util.concurrent.RecursiveAction.exec(RecursiveAction.java:189)
Nov 02 04:14:52 at java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:289)
Nov 02 04:14:52 at java.util.concurrent.ForkJoinPool$WorkQueue.runTask(ForkJoinPool.java:1056)
Please take a look.
I guess the reason is that Pulsar service uses Java 11 or Java 17 so that some methods cannot be found when Flink uses Java 8. |
Yep. I think you are right. We may have to override the caffeine or drop the mocked Pulsar instance by in favor of Test container. |
0aa0790
to
e61921b
Compare
e61921b
to
a967677
Compare
@flinkbot run azure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging...
What is the purpose of the change
Update the Pulsar dependency to 2.10.2 to benefit of the fixes highlighted at apache/[email protected] (release)
Brief change log
Update dependencies
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation