Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29668][Gelly] Remove Gelly #21096

Merged
merged 3 commits into from
Oct 19, 2022

Conversation

MartijnVisser
Copy link
Contributor

What is the purpose of the change

  • Remove Gelly

Brief change log

  • Adds deprecation warning for the DataSet API to all DataSet API documentation, not just the overview page
  • Removes all Gelly code
  • Removes Gelly documentation
  • Adds hint to check out Flink ML Iterations as a replacement for DataSet Iterations support in the DataSet deprecation warning

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 18, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@zentol zentol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a gelly reference in the javadocs of org.apache.flink.api.java.utils.DataSetUtils#checksumHashCode.

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time past quickly :)

@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@MartijnVisser
Copy link
Contributor Author

@flinkbot run azure

@MartijnVisser MartijnVisser merged commit a215d94 into apache:master Oct 19, 2022
@MartijnVisser MartijnVisser deleted the flink-29668-remove-gelly branch October 19, 2022 07:29
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
* [hotfix] Add hint warning about DataSets deprecation to all DataSet documentation pages and not just the overview page

* [FLINK-29668][Gelly] Remove Gelly
dchristle pushed a commit to dchristle/flink that referenced this pull request Nov 18, 2022
* [hotfix] Add hint warning about DataSets deprecation to all DataSet documentation pages and not just the overview page

* [FLINK-29668][Gelly] Remove Gelly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants