[FLINK-28820][Connector/Pulsar] Improve the writing performance for PulsarSink #21074
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
PulsarSink is slow when we use the
At-Least-Once
orExactly-Once
. This is because PulsarSink usesMailboxExecutor
to write messages. A lot of useless context switches and locks acquire happened when using this writing policy. We should dropMailboxExecutor
and send messages directly for better performance.Brief change log
PulsarSinkOptions.PULSAR_MAX_PENDING_MESSAGES_ON_PARALLELISM
option since Pulsar client has its own send rate limit by memory.MailboxExecutor
inPulsarWriter
.Verifying this change
This change is already covered by existing tests, such as PulsarWriterTest.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation