Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28820][Connector/Pulsar] Improve the writing performance for PulsarSink #21074

Merged
merged 1 commit into from
Oct 18, 2022

Conversation

syhily
Copy link
Contributor

@syhily syhily commented Oct 14, 2022

What is the purpose of the change

PulsarSink is slow when we use the At-Least-Once or Exactly-Once. This is because PulsarSink uses MailboxExecutor to write messages. A lot of useless context switches and locks acquire happened when using this writing policy. We should drop MailboxExecutor and send messages directly for better performance.

Brief change log

  • Deprecated useless PulsarSinkOptions.PULSAR_MAX_PENDING_MESSAGES_ON_PARALLELISM option since Pulsar client has its own send rate limit by memory.
  • Remove the use of MailboxExecutor in PulsarWriter.

Verifying this change

This change is already covered by existing tests, such as PulsarWriterTest.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable)

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 14, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@tisonkun tisonkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Merging...

@tisonkun tisonkun merged commit 3f863b1 into apache:master Oct 18, 2022
@syhily syhily deleted the pull/FLINK-28820 branch October 18, 2022 14:13
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
dchristle pushed a commit to dchristle/flink that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants