Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29532][Connector/Pulsar] Update Pulsar dependency to 2.10.1 #20980

Merged
merged 3 commits into from
Oct 10, 2022

Conversation

MartijnVisser
Copy link
Contributor

@MartijnVisser MartijnVisser commented Oct 6, 2022

What is the purpose of the change

Brief change log

  • Update dependencies

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): yes
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@MartijnVisser
Copy link
Contributor Author

@syhily @imaffe Can one of you have a look at this PR?

@flinkbot
Copy link
Collaborator

flinkbot commented Oct 6, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@syhily
Copy link
Contributor

syhily commented Oct 7, 2022

I think some test dependencies may need extra check. I'll review this PR latter today in China.

Copy link
Contributor

@syhily syhily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bouncycastle should be kept using 1.69. netty and grpc should bump theirs version.

@MartijnVisser
Copy link
Contributor Author

@syhily Thanks, I've made the changes. Please check again, I'll wait for CI to pass

Copy link
Contributor

@syhily syhily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MartijnVisser MartijnVisser merged commit f5f2e16 into apache:master Oct 10, 2022
@MartijnVisser MartijnVisser deleted the FLINK-29532-update-pulsar branch October 10, 2022 08:01
MartijnVisser added a commit to MartijnVisser/flink that referenced this pull request Oct 10, 2022
…his closes apache#20980

* [FLINK-29532][Connector/Pulsar] Update Pulsar dependency to 2.10.1

* [FLINK-29532][Connector/Pulsar] Fix NOTICE files

* Addressed review comments

(cherry picked from commit f5f2e16)
@MartijnVisser MartijnVisser self-assigned this Oct 10, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
…his closes apache#20980

* [FLINK-29532][Connector/Pulsar] Update Pulsar dependency to 2.10.1

* [FLINK-29532][Connector/Pulsar] Fix NOTICE files

* Addressed review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants