Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28698][runtime-web] fix order of aggregate durations to follow task state transitions #20372

Closed
wants to merge 2 commits into from

Conversation

yangjunhan
Copy link
Contributor

What is the purpose of the change

This PR closes FLINK-28698, which it fix the order of aggregated metrics status durations in order to follow the natural task state transitions: CREATED, SCHEDULED, DEPLOYING, INITIALIZING, RUNNING

Brief change log

Change the table row order to CREATED, SCHEDULED, DEPLOYING, INITIALIZING, RUNNING.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@yangjunhan
Copy link
Contributor Author

Hi, @xintongsong . This fix is relatively trivial. Could you help me review and merge this?

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 27, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yangjunhan. LGTM. Merging this once the CI passes.

@yangjunhan
Copy link
Contributor Author

@xintongsong Besides the previous commit, I have also fixed the order of duration badges in the subtask table. Please take a look at that as well, thanks.
image

Copy link
Contributor

@xintongsong xintongsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xintongsong
Copy link
Contributor

@flinkbot run azure

huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
@yangjunhan yangjunhan deleted the fix/runtime-web branch January 4, 2023 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants