[FLINK-28585][runtime] Ensure all the concurrent executions of SpeculativeExecutionVertex to share the same input splits #20322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecdec4b
to
34f2d48
Compare
wanglijie95
reviewed
Jul 25, 2022
There was a problem hiding this comment.
Thanks for creating this PR @zhuzhurk. I left some comments, please take a look.
...me/src/test/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertexTest.java
Outdated
Show resolved
Hide resolved
...untime/src/main/java/org/apache/flink/runtime/executiongraph/SpeculativeExecutionVertex.java
Show resolved
Hide resolved
…ativeExecutionVertex to share the same input splits This allows speculative execution for sources tasks from jobs with InputFormatSource.
4bbde3c
to
f737775
Compare
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
…ativeExecutionVertex to share the same input splits This allows speculative execution for sources tasks from jobs with InputFormatSource. This closes apache#20322.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This PR changes SpeculativeExecutionVertex to ensure all its concurrent executions to share the same input splits.
This allows speculative execution for sources tasks from jobs with InputFormatSource.
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation