[FLINK-28449][tests][JUnit5 migration] flink-parquet #20230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@flinkbot run azure |
XComp
requested changes
Oct 6, 2022
...arquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/apache/flink/formats/parquet/avro/AvroParquetStreamingFileSinkITCase.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/flink/formats/parquet/protobuf/ParquetProtoStreamingFileSinkITCase.java
Outdated
Show resolved
Hide resolved
...test/java/org/apache/flink/formats/parquet/protobuf/ParquetProtoStreamingFileSinkITCase.java
Show resolved
Hide resolved
...ink-parquet/src/test/java/org/apache/flink/formats/parquet/row/ParquetRowDataWriterTest.java
Show resolved
Hide resolved
...src/test/java/org/apache/flink/formats/parquet/vector/ParquetColumnarRowSplitReaderTest.java
Outdated
Show resolved
Hide resolved
RyanSkraba
force-pushed
the
rskraba/FLINK-28449-flink-parquet
branch
from
baaa6af
to
2022025
Compare
XComp
requested changes
Oct 26, 2022
There was a problem hiding this comment.
Thanks for addressing/answering my questions, @RyanSkraba . Two minor things are still required to change.
...arquet/src/test/java/org/apache/flink/formats/parquet/ParquetColumnarRowInputFormatTest.java
Show resolved
Hide resolved
...k-parquet/src/test/java/org/apache/flink/formats/parquet/avro/AvroParquetFileReadITCase.java
Show resolved
Hide resolved
XComp
approved these changes
Nov 4, 2022
|
I created FLINK-29893 to cover the build failure. |
|
I'm gonna merge this PR without rerunning the e2e tests because the change suggested by this PR is independent of the e2e tests. |
dchristle
pushed a commit
to dchristle/flink
that referenced
this pull request
Nov 18, 2022
akkinenivijay
pushed a commit
to krisnaru/flink
that referenced
this pull request
Feb 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Update the
flink-formats/flink-parquetmodule to AssertJ and JUnit 5 following the JUnit 5 Migration GuideBrief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
I've verified that there are 94 tests run in this module before and after the refactoring.
Does this pull request potentially affect one of the following parts:
@Public(Evolving): noDocumentation