[FLINK-28417][table] Add interfaces for LookupCache and default implementation #20196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c7771d
to
247f76a
Compare
wuchong
reviewed
Jul 28, 2022
There was a problem hiding this comment.
Thank @PatrickRen for the contribution. I left some comments.
...n/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java
Outdated
Show resolved
Hide resolved
...table-common/src/main/java/org/apache/flink/table/connector/source/lookup/LookupOptions.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java
Show resolved
Hide resolved
|
@wuchong Thanks for the review! I addresses your comments in the latest commit. Please take a look when you are available. |
wuchong
reviewed
Jul 29, 2022
...n/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java
Outdated
Show resolved
Hide resolved
...n/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java
Outdated
Show resolved
Hide resolved
SmirAlex
reviewed
Jul 29, 2022
There was a problem hiding this comment.
@PatrickRen, thanks for your contribution! I've left some minor comments, please check.
...n/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java
Outdated
Show resolved
Hide resolved
...table-common/src/main/java/org/apache/flink/table/connector/source/lookup/LookupOptions.java
Outdated
Show resolved
Hide resolved
...table-common/src/main/java/org/apache/flink/table/connector/source/lookup/LookupOptions.java
Outdated
Show resolved
Hide resolved
SmirAlex
reviewed
Jul 30, 2022
...n/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java
Outdated
Show resolved
Hide resolved
lincoln-lil
reviewed
Aug 1, 2022
| code(LookupCacheType.FULL.toString())) | ||
| .build()); | ||
|
|
||
| public static final ConfigOption<Integer> MAX_RETRIES = |
There was a problem hiding this comment.
It's better not to add this new option if we have no migration plan for existing connectors (e.g., hbase & jdbc), and it is not related with caching.
There was a problem hiding this comment.
Well we do plan to migrate hbase and jdbc to the new framework, so I prefer to keep this option.
...n/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java
Outdated
Show resolved
Hide resolved
1. Change serial ID to 1 2. Sanity check in constructor 3. Always register metrics in DefaultLookupCache#open 4. Change default value of max retries to 3
|
@wuchong @SmirAlex @lincoln-lil Thank you all for the review! I updated the PR to address your comments. Please take another look at your convenience. |
wuchong
reviewed
Aug 2, 2022
...n/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java
Show resolved
Hide resolved
...n/src/main/java/org/apache/flink/table/connector/source/lookup/cache/DefaultLookupCache.java
Outdated
Show resolved
Hide resolved
2. make error message more descriptive in DefaultLookupCache.fromConfig 3. Add test for builder and fromConfig
snuyanzin
pushed a commit
to snuyanzin/flink
that referenced
this pull request
Aug 4, 2022
huangxiaofeng10047
pushed a commit
to huangxiaofeng10047/flink
that referenced
this pull request
Nov 3, 2022
morozov
pushed a commit
to morozov/flink
that referenced
this pull request
Apr 26, 2024
…o enable mongodb connector to run with decodable-flink (apache#54) * [FLINK-28417][table] Add interfaces for LookupCache and default implementation (apache#20196) * manually add ThreadSafeSimpleCounter, which is the only missing dependency of LookupCache/DefaultLookupCache that is not in flink 1.15 --------- Co-authored-by: Qingsheng Ren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This pull request introduces interfaces for LookupCache and CacheMetricGroup, also a default implementation of LookupCache.
Brief change log
LookupCacheandCacheMetricGroupLookupCacheasDefaultLookupCacheCacheMetricGroupasInternalCacheMetricGroupVerifying this change
This change added unit tests for the newly added
DefaultLookupCacheandInternalCacheMetricGroupDoes this pull request potentially affect one of the following parts:
@Public(Evolving): (yes / no)Documentation