Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28198][connectors][cassandra] raise driver timeouts per session request and raise it higher than cluster side timetouts #20184

Conversation

echauchot
Copy link
Contributor

Contribution Checklist

What is the purpose of the change

Raise driver timeouts per session request and raise it higher than cluster side timetouts

Brief change log

Change in the CassandraITCase

Verifying this change

This change is already covered by existing tests, such as CassandraITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

R: @MartijnVisser

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 6, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

ResultSet result =
session.execute(
new SimpleStatement(injectTableName(SELECT_DATA_QUERY))
.setReadTimeoutMillis(READ_TIMEOUT_MILLIS));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this already set in the cluster builder?

Copy link
Contributor Author

@echauchot echauchot Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but as I wrote in the ticket:

"the driver timeouts were set on the clusterBuilder because previous timeout errors were only on test cases. Here, the request timeouts are on session.execute that do not use the ClusterBuilder. Thus, they use the default 12s timeout. I'll raise to 36s per session request."

the ClusterBuilder is only used for Sinks, InputFormats, OutputFormats, etc... but not for session.execute requests

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zentol there has been several of these timeout issues that make the build flaky. @MartijnVisser pinged me to quickly solve this issue. Tell me if you need anything more on this PR.

@echauchot echauchot force-pushed the FLINK-28198-raise-driver-timeouts-per-session-request branch from 4244419 to 24ae7bd Compare July 8, 2022 08:53
@echauchot
Copy link
Contributor Author

@flinkbot run azure

1 similar comment
@echauchot
Copy link
Contributor Author

@flinkbot run azure

Copy link
Contributor

@MartijnVisser MartijnVisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@echauchot Thanks for the PR. Let's get this merged :)

@MartijnVisser MartijnVisser merged commit 7cdf0e6 into apache:master Jul 18, 2022
JunRuiLee pushed a commit to JunRuiLee/flink that referenced this pull request Jul 20, 2022
…n request and raise it higher than cluster side timetouts (apache#20184)

* [FLINK-28198][connectors][cassandra] Raise driver timeouts per session request and raise it higher than cluster side timeouts. This closes apache#20184
liujiawinds pushed a commit to liujiawinds/flink that referenced this pull request Jul 22, 2022
…n request and raise it higher than cluster side timetouts (apache#20184)

* [FLINK-28198][connectors][cassandra] Raise driver timeouts per session request and raise it higher than cluster side timeouts. This closes apache#20184
@echauchot echauchot deleted the FLINK-28198-raise-driver-timeouts-per-session-request branch September 30, 2022 10:06
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
…n request and raise it higher than cluster side timetouts (apache#20184)

* [FLINK-28198][connectors][cassandra] Raise driver timeouts per session request and raise it higher than cluster side timeouts. This closes apache#20184
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants