Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-28416][table] Add (Async)LookupFunction and providers in replace of (Async)TableFunction as the API for lookup table #20177

Merged
merged 2 commits into from
Jul 27, 2022

Conversation

PatrickRen
Copy link
Contributor

What is the purpose of the change

This pull request introduces new interfaces in replace of the original TableFunction and its provider for lookup table, including:

  • LookupFunction
  • AsyncLookupFunction
  • LookupFunctionProvider
  • AsyncLookupFunctionProvider

Also mark TableFunctionProvider and AsyncTableFunctionProvider as deprecated.

Brief change log

  • Add (Async)LookupFunction interface and provider interfaces
  • Mark (Async)TableFunctionProvider as deprecated

Verifying this change

This PR only creates new and marks deprecated interfaces, which does not require test cases.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes)
  • The serializers: (no)
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (yes)
  • If yes, how is the feature documented? (JavaDocs)

@flinkbot
Copy link
Collaborator

flinkbot commented Jul 6, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Copy link
Contributor

@lincoln-lil lincoln-lil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PatrickRen thanks for your contribution!The pr looks good to me, I've left
some comments here, PTAL.

@PatrickRen
Copy link
Contributor Author

@lincoln-lil Thanks for the review! I've addressed your comments in the latest commit. Please take a look when you are available.

Copy link
Contributor

@lincoln-lil lincoln-lil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your updates @PatrickRen
LGTM! +1

@PatrickRen PatrickRen merged commit 3e2620b into apache:master Jul 27, 2022
huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
…ce of (Async)TableFunction as the API for lookup table (apache#20177)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants