[FLINK-1223] Allow value escaping in CSV files. #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strings can now contain " quoted characters Skip trailing whitespace after quote
|
Looks good. I have one inline comment/question, though |
| @@ -30,7 +34,14 @@ | |||
| private static final byte WHITESPACE_TAB = (byte) '\t'; | |||
|
|
|||
| private static final byte QUOTE_DOUBLE = (byte) '"'; | |||
|
|
|||
|
|
|||
| private static final Set<Byte> trailingCheckSet = Sets.newHashSet( | |||
There was a problem hiding this comment.
The parsers are often stressed badly when reading large CSV files, so we think a lot about performance here.
I am wondering if a hash set is the best choice to check for these three elements. Computing hash, table lookup, entry lookup, comparison, ...
Might be cheaper to just hardwire the check for those types...
There was a problem hiding this comment.
Do not use sets when comparing for unquoted characters
|
Thanks for having a look at the code Indeed the Set approach is nicer to read but there is a performance penalty incurred I just ran a simple caliper benchmark and on my machine the set approach is about 10x slower, so I fixed that. |
|
Looks good. |
|
OK. I'm merging this in the current batch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Strings can now contain " quoted characters
Skip trailing whitespace after quote