[FLINK-3523] [Storm-Compatibility] Added SplitStreamMapper to program… #1844
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Perhaps we could add a test case for this example? |
|
This is an additional example that runs forever -- it was never designed for getting tested. Furthermore, there are already two test for split-stream functionality. |
|
IMHO we should have a way to check that examples are working properly. We don't have to address this in this PR though. |
… to get rid of SplitStreamType wrapper
mjsax
force-pushed
the
flink-3523-split-example
branch
from
8e518b5
to
0502bd1
Compare
|
Change example slightly (make it run finite and added a check for even/odd stream) and added IT-Case. |
|
For the test, two comments:
|
added tmp files
|
Done. I needed to restructure class hierarchy, because |
| private static final long serialVersionUID = 5213888269197438892L; | ||
| private final Tuple2<String, Integer> out; | ||
| private final boolean evenOrOdd; // true: even -- false: odd |
|
Test fail on Java8 module... Can I merge this @mxm @StephanEwen? |
|
+1 to merge |
fijolekProjects
pushed a commit
to fijolekProjects/flink
that referenced
this pull request
May 1, 2016
… to get rid of SplitStreamType wrapper - additionally reworked split ITCases * unified to single test * make Windows compatible (using tmp files) * added test case for embedded splitting This closes apache#1844
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to get rid of SplitStreamType wrapper