-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-24865][CEP] Support MATCH_RECOGNIZE in Batch mode #18408
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 98deafa (Thu Jan 20 05:24:01 UTC 2022) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@SteNicholas I have to check, let me get back to you asap |
Thanks for working on this @SteNicholas. I will review it today or Monday latest. |
@twalthr @MartijnVisser, could anyone help to review this pull request? |
@SteNicholas sorry for the delay. The SQL upgrade story still keeps us busy. I guess we have to postpone this to Flink 1.16. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @SteNicholas, I left some comments and integration testing is missed
...anner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecMatch.java
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalMatch.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalMatch.scala
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalMatch.scala
Outdated
Show resolved
Hide resolved
.../scala/org/apache/flink/table/planner/plan/rules/physical/batch/BatchPhysicalMatchRule.scala
Outdated
Show resolved
Hide resolved
...anner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecMatch.java
Outdated
Show resolved
Hide resolved
...anner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/batch/BatchExecMatch.java
Outdated
Show resolved
Hide resolved
...lanner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/MatchRecognizeTest.scala
Outdated
Show resolved
Hide resolved
...lanner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/MatchRecognizeTest.scala
Outdated
Show resolved
Hide resolved
...lanner/src/test/scala/org/apache/flink/table/planner/plan/batch/sql/MatchRecognizeTest.scala
Outdated
Show resolved
Hide resolved
@godfreyhe, I have addressed the above comments and updated this pull request. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, I left some comments
.../test/java/org/apache/flink/table/api/batch/sql/validation/MatchRecognizeValidationTest.java
Show resolved
Hide resolved
...ner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecMatch.java
Outdated
Show resolved
Hide resolved
...ner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecMatch.java
Outdated
Show resolved
Hide resolved
...ner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecMatch.java
Outdated
Show resolved
Hide resolved
...ner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecMatch.java
Show resolved
Hide resolved
.../java/org/apache/flink/table/planner/plan/rules/physical/common/CommonPhysicalMatchRule.java
Outdated
Show resolved
Hide resolved
...main/scala/org/apache/flink/table/planner/plan/nodes/physical/batch/BatchPhysicalMatch.scala
Outdated
Show resolved
Hide resolved
...in/scala/org/apache/flink/table/planner/plan/nodes/physical/common/CommonPhysicalMatch.scala
Outdated
Show resolved
Hide resolved
.../scala/org/apache/flink/table/planner/plan/rules/physical/batch/BatchPhysicalMatchRule.scala
Outdated
Show resolved
Hide resolved
...-planner/src/test/java/org/apache/flink/table/planner/plan/batch/sql/MatchRecognizeTest.java
Show resolved
Hide resolved
@godfreyhe, thanks for your review. I have addressed above comments. PTAL. |
Thanks for the update, LGTM |
@flinkbot run azure |
What is the purpose of the change
MATCH_RECOGNIZE
only works currently in Streaming mode. It should also be supported in Batch mode.Brief change log
FlinkBatchRuleSets
adds theBatchPhysicalMatchRule
for the batch rule of theMATCH_RECOGNIZE
.BatchExecMatch
to add the batchExecNode
which matches along withMATCH_RECOGNIZE
.Verifying this change
BatchOperatorNameTest
adds thetestMatch
test case for the batch operator of theMATCH_RECOGNIZE
.MatchRecognizeTest
andMatchRecognizeValidationTest
for the batch mode of theMATCH_RECOGNIZE
.Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation