Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view #17352

Merged
merged 1 commit into from
Oct 26, 2021

Conversation

RocMarshal
Copy link
Contributor

What is the purpose of the change

Support 'SHOW CREATE VIEW' syntax to print the query of a view

Brief change log

Support 'SHOW CREATE VIEW' syntax to print the query of a view

Verifying this change

This change added tests and can be verified as follows:

  • org.apache.flink.table.planner.catalog.CatalogViewITCase

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
  • The serializers: (yes / no / don't know)
  • The runtime per-record code paths (performance sensitive): (yes / no / don't know)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / no / don't know)
  • The S3 file system connector: (yes / no / don't know)

Documentation

  • Does this pull request introduce a new feature? (yes / no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

@flinkbot
Copy link
Collaborator

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3af1ce2 (Fri Sep 24 12:55:28 UTC 2021)

✅no warnings

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Sep 24, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

@RocMarshal
Copy link
Contributor Author

RocMarshal commented Sep 26, 2021

@Airblader @wuchong Thank you for your comments. I made some changes based on your suggestions. Please let me know what's your opinion.

Copy link
Contributor

@Airblader Airblader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is looking much better already! I think we could maybe make a few more changes. What do you think?

@RocMarshal
Copy link
Contributor Author

@flinkbot run azure

@RocMarshal
Copy link
Contributor Author

@Airblader Thank you so much for your suggestions. I updated the pr. PTAL.

Copy link
Contributor

@Airblader Airblader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RocMarshal! This looks largely good to me now, minus a couple more comments of which most are nits. We'll need a committer to look at this now.

@RocMarshal
Copy link
Contributor Author

RocMarshal commented Oct 1, 2021

Thanks @Airblader for the review.
Hi, @wuchong , @xintongsong @twalthr @rmetzger @pnowojski @fsk119 . Could you help me to merge it if there are nothing inappropriate ? Thank you.

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great contribution @RocMarshal and sorry for the late reviewing.
I left some comments.

@RocMarshal
Copy link
Contributor Author

RocMarshal commented Oct 21, 2021

@wuchong I really appreciate it. I make some change based on your suggestions. PTAL.

Copy link
Member

@wuchong wuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updating. I will help to rebase and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants