-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-10230][table] Support 'SHOW CREATE VIEW' syntax to print the query of a view #17352
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3af1ce2 (Fri Sep 24 12:55:28 UTC 2021) ✅no warnings Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
...k-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
Outdated
Show resolved
Hide resolved
...-table-planner/src/test/scala/org/apache/flink/table/planner/catalog/CatalogViewITCase.scala
Outdated
Show resolved
Hide resolved
flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/dql/SqlShowCreate.java
Outdated
Show resolved
Hide resolved
...k-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
Outdated
Show resolved
Hide resolved
...k-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
Outdated
Show resolved
Hide resolved
...k-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
Outdated
Show resolved
Hide resolved
...-table-planner/src/test/scala/org/apache/flink/table/planner/catalog/CatalogViewITCase.scala
Outdated
Show resolved
Hide resolved
...-table-planner/src/test/scala/org/apache/flink/table/planner/catalog/CatalogViewITCase.scala
Outdated
Show resolved
Hide resolved
...k-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
Outdated
Show resolved
Hide resolved
058c1af
to
374b1e5
Compare
@Airblader @wuchong Thank you for your comments. I made some changes based on your suggestions. Please let me know what's your opinion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this is looking much better already! I think we could maybe make a few more changes. What do you think?
...k-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
Outdated
Show resolved
Hide resolved
...k-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
Outdated
Show resolved
Hide resolved
...k-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java
Outdated
Show resolved
Hide resolved
98f5263
to
f1b1ebf
Compare
@flinkbot run azure |
@Airblader Thank you so much for your suggestions. I updated the pr. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RocMarshal! This looks largely good to me now, minus a couple more comments of which most are nits. We'll need a committer to look at this now.
...e/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java
Outdated
Show resolved
Hide resolved
...e/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java
Outdated
Show resolved
Hide resolved
...e/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java
Outdated
Show resolved
Hide resolved
...e/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java
Outdated
Show resolved
Hide resolved
f1b1ebf
to
3d03869
Compare
Thanks @Airblader for the review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the great contribution @RocMarshal and sorry for the late reviewing.
I left some comments.
...e/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java
Show resolved
Hide resolved
...e/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/ShowCreateUtil.java
Outdated
Show resolved
Hide resolved
...-table-planner/src/test/scala/org/apache/flink/table/planner/catalog/CatalogViewITCase.scala
Outdated
Show resolved
Hide resolved
3d03869
to
d45a1f7
Compare
@wuchong I really appreciate it. I make some change based on your suggestions. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updating. I will help to rebase and merge it.
…uery of a view This closes apache#17352
…uery of a view This closes apache#17352
What is the purpose of the change
Support 'SHOW CREATE VIEW' syntax to print the query of a view
Brief change log
Support 'SHOW CREATE VIEW' syntax to print the query of a view
Verifying this change
This change added tests and can be verified as follows:
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (yes / no)Documentation