-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-23899][docs-zh] Translate the "Elastic Scaling" page into Chinese #16928
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 371d9ad (Sun Aug 22 06:02:31 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@predatorray Thanks for creating this PR. The translation LGTM in general. I left some minor comments, PTAL.
|
||
If you just want to try out Reactive Mode, follow these instructions. They assume that you are deploying Flink on a single machine. | ||
<a name="getting-started"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there an extra link tag without the actual URL?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your explanation! WRT to the anchor question, cc @wuchong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this line is needed if we would like to preserve the original tag links.
|
||
This page describes options where Flink automatically adjusts the parallelism instead. | ||
这个文档描述的特性是 Flink 如何自动地调整并行度。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 'options' might not be correctly translated. options
means users can choose either reactive mode or adaptive scheduler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the revised translation:
809752c#diff-69b2dca8ca68dd36524d019124dd2eef1e7914f45f6992733e7d221c13b68ea9R30
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Thanks for the work @predatorray , @link3280 |
What is the purpose of the change
Translated the "Elastic Scaling" page into Chinese.
Brief change log
Translated the "Elastic Scaling" page into Chinese.
Verifying this change
This change is a translation without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: noDocumentation