-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22518][docs] Translate the page of "High Availability (HA)" in… #16084
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 3aa2cd2 (Sat Aug 28 12:17:57 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions!
I have given some suggestions below, please take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@movesan, Overall, it looks good to me. Would you please combine the three commits into one single commit and ensure the commit message is full and clean? You can then force push your commits to your branch to update this PR.
b1a0329
to
17f27b7
Compare
|
@movesan , thanks for your update! |
…view", "High Availability/ZooKeeper HA Services", "High Availability/Kubernetes HA Services" into Chinese(apache#16084)
17f27b7
to
3aa2cd2
Compare
@Myasuka Hi Myasuka, thank you for your review, I have modified to a more detailed comment. Please check it, thx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nto Chinese(apache#16084) (apache#16084) This fix apache#16084.
What is the purpose of the change
Translate "High Availability" page into Chinese.
The model of "High Availability (HA)" contains the following three pages:
https://ci.apache.org/projects/flink/flink-docs-release-1.12/zh/deployment/ha
https://ci.apache.org/projects/flink/flink-docs-release-1.12/zh/deployment/ha/zookeeper_ha.html
https://ci.apache.org/projects/flink/flink-docs-release-1.12/zh/deployment/ha/kubernetes_ha.html
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation