Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-22518][docs] Translate the page of "High Availability (HA)" in… #16084

Merged
merged 1 commit into from
Jun 18, 2021

Conversation

movesan
Copy link
Contributor

@movesan movesan commented Jun 6, 2021

What is the purpose of the change

Translate "High Availability" page into Chinese.

The model of "High Availability (HA)" contains the following three pages:
https://ci.apache.org/projects/flink/flink-docs-release-1.12/zh/deployment/ha
https://ci.apache.org/projects/flink/flink-docs-release-1.12/zh/deployment/ha/zookeeper_ha.html
https://ci.apache.org/projects/flink/flink-docs-release-1.12/zh/deployment/ha/kubernetes_ha.html

Brief change log

  • translate flink/docs/content.zh/docs/deployment/ha/_index.md
  • translate flink/docs/content.zh/docs/deployment/ha/overview.md
  • translate flink/docs/content.zh/docs/deployment/ha/zookeeper_ha.md
  • translate flink/docs/content.zh/docs/deployment/ha/kubernetes_ha.md

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @Public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (no)

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 6, 2021

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3aa2cd2 (Sat Aug 28 12:17:57 UTC 2021)

Warnings:

  • No documentation files were touched! Remember to keep the Flink docs up to date!

Mention the bot in a comment to re-run the automated checks.

Review Progress

  • ❓ 1. The [description] looks good.
  • ❓ 2. There is [consensus] that the contribution should go into to Flink.
  • ❓ 3. Needs [attention] from.
  • ❓ 4. The change fits into the overall [architecture].
  • ❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.


The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commands
The @flinkbot bot supports the following commands:

  • @flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
  • @flinkbot approve all to approve all aspects
  • @flinkbot approve-until architecture to approve everything until architecture
  • @flinkbot attention @username1 [@username2 ..] to require somebody's attention
  • @flinkbot disapprove architecture to remove an approval you gave earlier

@flinkbot
Copy link
Collaborator

flinkbot commented Jun 6, 2021

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run travis re-run the last Travis build
  • @flinkbot run azure re-run the last Azure build

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions!
I have given some suggestions below, please take a look.

docs/content.zh/docs/deployment/ha/kubernetes_ha.md Outdated Show resolved Hide resolved
docs/content.zh/docs/deployment/ha/kubernetes_ha.md Outdated Show resolved Hide resolved
docs/content.zh/docs/deployment/ha/overview.md Outdated Show resolved Hide resolved
docs/content.zh/docs/deployment/ha/zookeeper_ha.md Outdated Show resolved Hide resolved
Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@movesan, Overall, it looks good to me. Would you please combine the three commits into one single commit and ensure the commit message is full and clean? You can then force push your commits to your branch to update this PR.

@movesan
Copy link
Contributor Author

movesan commented Jun 18, 2021

@movesan, Overall, it looks good to me. Would you please combine the three commits into one single commit and ensure the commit message is full and clean? You can then force push your commits to your branch to update this PR.
@Myasuka Hi Myasuka, thank you for your reply. I have combined the three commits into one single commit, Could you merge this PR into the master? Thanks a lot.

@movesan movesan requested a review from Myasuka June 18, 2021 05:58
@Myasuka
Copy link
Member

Myasuka commented Jun 18, 2021

@movesan , thanks for your update!
However, the commit message is still not full and clean, it should not be [FLINK-22518][docs] Translate the page of "High Availability (HA)" in…. Please amend your commit message and then force push it.

…view", "High Availability/ZooKeeper HA Services", "High Availability/Kubernetes HA Services" into Chinese(apache#16084)
@movesan
Copy link
Contributor Author

movesan commented Jun 18, 2021

@Myasuka Hi Myasuka, thank you for your review, I have modified to a more detailed comment. Please check it, thx.

Copy link
Member

@Myasuka Myasuka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Myasuka Myasuka merged commit fc73b3f into apache:master Jun 18, 2021
luoyuxia pushed a commit to luoyuxia/flink that referenced this pull request Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants