-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-22865][python] Optimize state serialize/deserialize in PyFlink #16069
Conversation
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community Automated ChecksLast check on commit 98e5b65 (Tue Dec 14 09:04:54 UTC 2021) Warnings:
Mention the bot in a comment to re-run the automated checks. Review Progress
Please see the Pull Request Review Guide for a full explanation of the review process. The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required Bot commandsThe @flinkbot bot supports the following commands:
|
@@ -1136,7 +1136,7 @@ def get_execution_environment(self): | |||
return self._keyed_stream.get_execution_environment() | |||
|
|||
def get_input_type(self): | |||
return self._keyed_stream.get_type() | |||
return _from_java_type(self._keyed_stream._original_data_type_info.get_java_type_info()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of this change?
return BinaryCoder() | ||
else: | ||
return PrimitiveArrayCoder(from_type_info(element_type)) | ||
elif isinstance(type_info, BasicArrayTypeInfo): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should also consider ObjectArrayTypeInfo
@@ -324,11 +323,12 @@ def open(self, runtime_context: RuntimeContext, internal_timer_service: Internal | |||
# TODO: the type info is just a placeholder currently. | |||
# it should be the real type serializer after supporting the user-defined state type | |||
# serializer | |||
merging_sets_state_descriptor = ListStateDescriptor( | |||
"merging-window-set", Types.PICKLED_BYTE_ARRAY()) | |||
# merging_sets_state_descriptor = ListStateDescriptor( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could just remove the code
def decode_from_stream(self, in_stream, length=0): | ||
return self._decode_one_value_from_stream(in_stream) | ||
|
||
def _decode_one_value_from_stream(self, in_stream: InputStream): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems not necessary to introduce such a method
What is the purpose of the change
This pull request optimize state serialize/deserialize in PyFlink
Brief change log
Verifying this change
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation