[FLINK-22844]Add doc to introduce ExplainDetails for EXPLAIN sytnax #16051

chaozwn · 2021-06-02T07:17:15Z

What is the purpose of the change

(For example: This pull request makes task deployment go through the blob server, rather than through RPC. That way we avoid re-transferring them on each deployment (during recovery).)

Brief change log

(for example:)

The TaskInfo is stored in the blob store on job creation time as a persistent artifact
Deployments RPC transmits only the blob storage reference
TaskManagers retrieve the TaskInfo from the blob cache

Verifying this change

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

Added integration tests for end-to-end deployment with large payloads (100MB)
Extended integration test for recovery after master (JobManager) failure
Added test that validates that TaskInfo is transferred only once across recoveries
Manually verified the change by running a 4 node cluser with 2 JobManagers and 4 TaskManagers, a stateful streaming program, and killing one JobManager and two TaskManagers during the execution, verifying that recovery happens correctly.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

flinkbot · 2021-06-02T07:22:54Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit c4831e9 (Wed Jun 02 07:22:54 UTC 2021)

✅no warnings

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2021-06-02T07:41:09Z

CI report:

6ef5adc Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

leonardBang

Thanks @chaozwn for the contribution, the content looks good, I left some syntax comments.

leonardBang · 2021-07-06T11:34:36Z

docs/content.zh/docs/dev/table/sql/explain.md

@@ -30,6 +30,7 @@ under the License.

 EXPLAIN statements are used to explain the logical and optimized query plans of a query or an INSERT statement.

+


revert the unnecessary change

leonardBang · 2021-07-06T11:38:19Z

docs/content.zh/docs/dev/table/sql/explain.md

 {{< top >}}

+## ExplainDetails
+```sql


The quoted content is not SQL

leonardBang · 2021-07-06T11:38:38Z

docs/content.zh/docs/dev/table/sql/explain.md

+
+

leonardBang · 2021-07-06T11:38:55Z

docs/content.zh/docs/dev/table/sql/explain.md

 ```

+


leonardBang · 2021-07-06T11:40:07Z

docs/content/docs/dev/table/sql/explain.md

 {{< top >}}

+## ExplainDetails
+```text


leonardBang · 2021-07-06T11:40:20Z

docs/content/docs/dev/table/sql/explain.md

+
+

leonardBang · 2021-07-20T02:36:15Z

@chaozwn Thanks for the update, but when we resolve reviewer's comment, we should append commit rather than squashing and force pushing which we cannot know the comment is fixed or not, because the squash way can not compare with previous comment and reviewer have to review again.

chaozwn · 2021-07-20T02:46:18Z

@chaozwn Thanks for the update, but when we resolve reviewer's comment, we should append commit rather than squashing and force pushing which we cannot know the comment is fixed or not, because the squash way can not compare with previous comment and reviewer have to review again.

I'm very sorry about do this.The reason why I use force push is because the latest version of flink is too big, and I need to re-merge a large number of branches in the code, and this may cause the display of this branch to be abnormal.

chaozwn · 2021-07-20T02:48:13Z

@chaozwn Thanks for the update, but when we resolve reviewer's comment, we should append commit rather than squashing and force pushing which we cannot know the comment is fixed or not, because the squash way can not compare with previous comment and reviewer have to review again.

in next time, I will choose rebase master carefully

leonardBang · 2021-07-20T03:00:40Z

Yes, rebasing master is recommended, and it doesn't matter.

leonardBang

@chaozwn Sorry for the late response, I left minor comments, Could you also update your commit message which should be [FLINK-22844] ?

leonardBang · 2021-08-17T01:47:18Z

docs/content.zh/docs/dev/table/sql/explain.md

+Flink SQL> CREATE TABLE MyTable1 (`count` bigint, word VARCHAR(256)) WITH ('connector' = 'datagen');
 [INFO] Table has been created.

-Flink SQL> CREATE TABLE MyTable2 (`count` bigint, word VARCHAR(256);
+Flink SQL> CREATE TABLE MyTable2 (`count` bigint, word VARCHAR(256)) WITH ('connector' = 'datagen');


Nice change, could you also add connector option for other languages?

leonardBang · 2021-08-17T01:47:46Z

docs/content.zh/docs/dev/table/sql/explain.md

+
+{{< tabs "explain result" >}}
+
+{{< tab "PLAN FOR" >}}


Suggested change

{{< tab "PLAN FOR" >}}

{{< tab "EXPLAIN PLAN" >}}

leonardBang · 2021-08-17T01:48:20Z

docs/content.zh/docs/dev/table/sql/explain.md

+
+{{< /tab >}}
+
+{{< tab "EXPLAINDETAILS" >}}


Suggested change

{{< tab "EXPLAINDETAILS" >}}

{{< tab "EXPLAIN PLAN WITH DETAILS" >}}

I have completed the modification.

adapt explain detail new function, add description how to use explain details.

leonardBang

Thanks for he update @chaozwn , LGTM

wuchong · 2021-08-17T11:39:28Z

Merging...

…ils for EXPLAIN sytnax (apache#16051)

rmetzger added the review=description? label Jun 2, 2021

rmetzger added component=Documentation component=TableSQL/API labels Jun 2, 2021

mans2singh mentioned this pull request Jul 6, 2021

[FLINK-23256][docs][table] - Updated explain output to that of blink planner #16380

Merged

leonardBang reviewed Jul 6, 2021

View reviewed changes

[FLINK-20562]support ExplainDetails for EXPLAIN sytnax

a24d658

chaozwn force-pushed the FLINK-22844 branch from c4831e9 to a24d658 Compare July 20, 2021 02:23

leonardBang reviewed Aug 17, 2021

View reviewed changes

chaozwn added 2 commits August 17, 2021 14:34

Update explain.md

675a297

adapt explain detail new function, add description how to use explain details.

Update explain.md

6ef5adc

adapt explain detail new function, add description how to use explain details.

leonardBang approved these changes Aug 17, 2021

View reviewed changes

wuchong merged commit 6ce650c into apache:master Aug 17, 2021

hhkkxxx133 pushed a commit to hhkkxxx133/flink that referenced this pull request Aug 25, 2021

[FLINK-22844][docs][table] Add documentation to introduce ExplainDeta…

c171f4a

…ils for EXPLAIN sytnax (apache#16051)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-22844]Add doc to introduce ExplainDetails for EXPLAIN sytnax #16051

[FLINK-22844]Add doc to introduce ExplainDetails for EXPLAIN sytnax #16051

chaozwn commented Jun 2, 2021

flinkbot commented Jun 2, 2021

flinkbot commented Jun 2, 2021 •

edited

Loading

leonardBang left a comment

leonardBang Jul 6, 2021

leonardBang Jul 6, 2021

leonardBang Jul 6, 2021

leonardBang Jul 6, 2021

leonardBang Jul 6, 2021

leonardBang Jul 6, 2021

leonardBang commented Jul 20, 2021

chaozwn commented Jul 20, 2021

chaozwn commented Jul 20, 2021

leonardBang commented Jul 20, 2021

leonardBang left a comment

leonardBang Aug 17, 2021

leonardBang Aug 17, 2021

leonardBang Aug 17, 2021

chaozwn Aug 17, 2021

leonardBang left a comment

wuchong commented Aug 17, 2021

		@@ -30,6 +30,7 @@ under the License.

		EXPLAIN statements are used to explain the logical and optimized query plans of a query or an INSERT statement.

	{{< tab "EXPLAINDETAILS" >}}
	{{< tab "EXPLAIN PLAN WITH DETAILS" >}}

[FLINK-22844]Add doc to introduce ExplainDetails for EXPLAIN sytnax #16051

[FLINK-22844]Add doc to introduce ExplainDetails for EXPLAIN sytnax #16051

Conversation

chaozwn commented Jun 2, 2021

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented Jun 2, 2021

Automated Checks

Review Progress

flinkbot commented Jun 2, 2021 • edited Loading

CI report:

leonardBang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leonardBang commented Jul 20, 2021

chaozwn commented Jul 20, 2021

chaozwn commented Jul 20, 2021

leonardBang commented Jul 20, 2021

leonardBang left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

leonardBang left a comment

Choose a reason for hiding this comment

wuchong commented Aug 17, 2021

flinkbot commented Jun 2, 2021 •

edited

Loading