[FLINK-21464][sql-client] Support ADD JAR in SQL Client #15925

fsk119 · 2021-05-17T03:01:02Z

What is the purpose of the change

Support ADD JAR in SQL Client.

Brief change log

Add grammer in calcite parser
SessionContext supports to create a new classloader and adds the added URL into the configuration

Verifying this change

This change added tests and can be verified as follows:

Add end to end test in CliClientTest (load the function in added jar, RESET should reset the classloader also)
Test SessionContext to add the legal/illegal path.

Does this pull request potentially affect one of the following parts:

Dependencies (does it add or upgrade a dependency): (yes / no)
The public API, i.e., is any changed class annotated with @Public(Evolving): (yes / no)
The serializers: (yes / no / don't know)
The runtime per-record code paths (performance sensitive): (yes / no / don't know)
Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: (yes / no / don't know)
The S3 file system connector: (yes / no / don't know)

Documentation

Does this pull request introduce a new feature? (yes / no)
If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)

flinkbot · 2021-05-17T03:09:24Z

Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.

Automated Checks

Last check on commit 3f79a63 (Sat Aug 28 12:12:42 UTC 2021)

Warnings:

No documentation files were touched! Remember to keep the Flink docs up to date!

_{Mention the bot in a comment to re-run the automated checks.}

Review Progress

❓ 1. The [description] looks good.
❓ 2. There is [consensus] that the contribution should go into to Flink.
❓ 3. Needs [attention] from.
❓ 4. The change fits into the overall [architecture].
❓ 5. Overall code [quality] is good.

Please see the Pull Request Review Guide for a full explanation of the review process.

The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot approve description to approve one or more aspects (aspects: description, consensus, architecture and quality)
@flinkbot approve all to approve all aspects
@flinkbot approve-until architecture to approve everything until architecture
@flinkbot attention @username1 [@username2 ..] to require somebody's attention
@flinkbot disapprove architecture to remove an approval you gave earlier

flinkbot · 2021-05-17T03:17:23Z

CI report:

8119d47 UNKNOWN
3f79a63 Azure: SUCCESS

Bot commands

The @flinkbot bot supports the following commands:

@flinkbot run travis re-run the last Travis build
@flinkbot run azure re-run the last Azure build

flink-table/flink-sql-parser-hive/src/main/codegen/data/Parser.tdd

flink-table/flink-sql-client/src/main/java/org/apache/flink/table/client/cli/CliStrings.java

...k-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java

...link-sql-client/src/main/java/org/apache/flink/table/client/gateway/local/LocalExecutor.java

wuchong · 2021-05-20T14:42:17Z

...k-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java

+ // check the jar path is legal
+ URL jar;
+ try {
+ jar = fromLocalFile(new File(jarPath).getAbsoluteFile()).toUri().toURL();


Please add some negative tests, e.g. jar from remote url .

...k-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java

...l-client/src/test/java/org/apache/flink/table/client/gateway/context/SessionContextTest.java

flink-table/flink-sql-client/src/test/resources/sql/function.q

…ble/client/cli/CliStrings.java Co-authored-by: Jark Wu <[email protected]>

...k-sql-client/src/main/java/org/apache/flink/table/client/gateway/context/SessionContext.java

flink-table/flink-sql-client/src/test/resources/sql/set.q

...l-client/src/test/java/org/apache/flink/table/client/gateway/context/SessionContextTest.java

...-table/flink-sql-client/src/test/java/org/apache/flink/table/client/cli/CliClientITCase.java

...l-client/src/test/java/org/apache/flink/table/client/gateway/context/SessionContextTest.java

wuchong

LGTM

* upstream/master: (23 commits) [FLINK-22760][Connectors/Hive] Fix issue of HiveParser::setCurrentTimestamp fails with hive-3.1.2 [FLINK-20140][python][docs] Add documentation for TableResult.collect for Python Table API. [FLINK-22780][streaming] Remove volatile from the idle flag in StreamSourceContexts [hotfix][runtime] Remove unused field from OperatorChain [FLINK-22746][docs] Links to connectors in docs are broken [FLINK-22393][docs-zh] Translate the page of "Execution Mode (Batch/Streaming)" into Chinese (apache#15767) [FLINK-21464][sql-client] Support ADD JAR in SQL Client (apache#15925) [FLINK-22777][docs] Restored full Datastream API fraud detection example in Try Flink section [FLINK-22778] Upgrade to JUnit 4.13 [FLINK-22613][tests] Fix FlinkKinesisITCase.testStopWithSavepoint. [FLINK-22784][jepsen] Update rest server leader path [FLINK-22774][sql-connector-kinesis] Update Kinesis SQL connector's Guava to 27.0-jre [FLINK-22740][docs] Drop legacy planner references in docs [FLINK-22319][table][sql-client] Support RESET table option for ALTER TABLE statement fixup: Create the new operator states instead of changing old one [FLINK-22684][runtime] Added ability to ignore in-flight data during the recovery [FLINK-22725][coordination] SlotManagers unregister metrics in suspend() [FLINK-22464][runtime][tests] Disable a test failing with AdaptiveScheduler tracked in FLINK-22464 [FLINK-22639] Override URLClassLoader#getURLs [FLINK-22747] Upgrade to commons-io 2.8.0 ...

fsk119 mentioned this pull request May 17, 2021

[FLINK-22064][sql-client] Support ADD JAR command in sql client #15558

Closed

fsk119 force-pushed the FLINK-21464 branch from 8119d47 to 9f54567 Compare May 17, 2021 03:07

rmetzger added the review=description? label May 17, 2021

rmetzger added the component=TableSQL/Client label May 17, 2021

fsk119 force-pushed the FLINK-21464 branch from 9f54567 to 3340cf6 Compare May 17, 2021 05:47

wuchong reviewed May 20, 2021

View reviewed changes

taox and others added 4 commits May 21, 2021 11:15

[FLINK-22064][sql-client] Support ADD JAR command in sql client

131b2c7

[FLINK-22064][sql-client] Support ADD JAR in SQL Client

b2e7372

Update flink-table/flink-sql-client/src/main/java/org/apache/flink/ta…

f3e6f76

…ble/client/cli/CliStrings.java Co-authored-by: Jark Wu <[email protected]>

[fix] address comments

692e6cd

fsk119 force-pushed the FLINK-21464 branch from a566bb9 to 692e6cd Compare May 21, 2021 06:12

fsk119 added 3 commits May 21, 2021 15:40

[fix] fix check style

3ac88d1

[fix] minor fix

a108131

[fix] fix the broken test

11ad41f

wuchong reviewed May 25, 2021

View reviewed changes

[fix] address the comments

3f79a63

wuchong approved these changes May 26, 2021

View reviewed changes

wuchong merged commit 34ff753 into apache:master May 27, 2021

fsk119 deleted the FLINK-21464 branch November 22, 2021 07:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FLINK-21464][sql-client] Support ADD JAR in SQL Client #15925

[FLINK-21464][sql-client] Support ADD JAR in SQL Client #15925

fsk119 commented May 17, 2021

flinkbot commented May 17, 2021 •

edited

Loading

flinkbot commented May 17, 2021 •

edited

Loading

wuchong May 20, 2021

wuchong left a comment

[FLINK-21464][sql-client] Support ADD JAR in SQL Client #15925

[FLINK-21464][sql-client] Support ADD JAR in SQL Client #15925

Conversation

fsk119 commented May 17, 2021

What is the purpose of the change

Brief change log

Verifying this change

Does this pull request potentially affect one of the following parts:

Documentation

flinkbot commented May 17, 2021 • edited Loading

Automated Checks

Review Progress

flinkbot commented May 17, 2021 • edited Loading

CI report:

wuchong May 20, 2021

Choose a reason for hiding this comment

wuchong left a comment

Choose a reason for hiding this comment

flinkbot commented May 17, 2021 •

edited

Loading

flinkbot commented May 17, 2021 •

edited

Loading